diff mbox series

[next] coredump: Remove redundant initialization of variable core_waiters

Message ID 20211011131635.30852-1-colin.king@canonical.com (mailing list archive)
State New, archived
Headers show
Series [next] coredump: Remove redundant initialization of variable core_waiters | expand

Commit Message

Colin King Oct. 11, 2021, 1:16 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The variable core_waiters is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and can
be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fs/coredump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christian Brauner Oct. 12, 2021, 10:39 a.m. UTC | #1 
On Mon, Oct 11, 2021 at 02:16:35PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable core_waiters is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and can
> be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---

Thanks!
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
diff mbox series

Patch

diff --git a/fs/coredump.c b/fs/coredump.c
index a6b3c196cdef..2f79f8f7bd56 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -390,7 +390,7 @@  static int zap_threads(struct task_struct *tsk,
 static int coredump_wait(int exit_code, struct core_state *core_state)
 {
 	struct task_struct *tsk = current;
-	int core_waiters = -EBUSY;
+	int core_waiters;
 
 	init_completion(&core_state->startup);
 	core_state->dumper.task = tsk;