| Message ID | 20220119220248.32225-1-ailiop@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | devtmpfs: drop redundant fs parameters from internal fs | expand |
On Wed, Jan 19, 2022 at 11:02:48PM +0100, Anthony Iliopoulos wrote: > The internal_fs_type is mounted via vfs_kernel_mount() and is never > registered as a filesystem, thus specifying the parameters is redundant > as those params will not be validated by fs_validate_description(). > > Both {shmem,ramfs}_fs_parameters are anyway validated when those > respective filesystems are first registered, so there is no reason to > pass them to devtmpfs too, drop them. Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
On Wed, Jan 19, 2022 at 11:02:48PM +0100, Anthony Iliopoulos wrote: > The internal_fs_type is mounted via vfs_kernel_mount() and is never > registered as a filesystem, thus specifying the parameters is redundant > as those params will not be validated by fs_validate_description(). > > Both {shmem,ramfs}_fs_parameters are anyway validated when those > respective filesystems are first registered, so there is no reason to > pass them to devtmpfs too, drop them. > > Signed-off-by: Anthony Iliopoulos <ailiop@suse.com> > --- Ah yes, I "complained" about this on the patch re-enabling reconfigure_mnt() for devtmpfs. Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c index f41063ac1aee..ad5f304e2b30 100644 --- a/drivers/base/devtmpfs.c +++ b/drivers/base/devtmpfs.c @@ -81,10 +81,8 @@ static struct file_system_type internal_fs_type = { .name = "devtmpfs", #ifdef CONFIG_TMPFS .init_fs_context = shmem_init_fs_context, - .parameters = shmem_fs_parameters, #else .init_fs_context = ramfs_init_fs_context, - .parameters = ramfs_fs_parameters, #endif .kill_sb = kill_litter_super, };
The internal_fs_type is mounted via vfs_kernel_mount() and is never registered as a filesystem, thus specifying the parameters is redundant as those params will not be validated by fs_validate_description(). Both {shmem,ramfs}_fs_parameters are anyway validated when those respective filesystems are first registered, so there is no reason to pass them to devtmpfs too, drop them. Signed-off-by: Anthony Iliopoulos <ailiop@suse.com> --- drivers/base/devtmpfs.c | 2 -- 1 file changed, 2 deletions(-)