mbox series

[GIT,PULL] vfs: fixes for 5.17-rc1

Message ID 20220205025100.GW8313@magnolia (mailing list archive)
State New
Headers show
Series [GIT,PULL] vfs: fixes for 5.17-rc1 | expand


git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/vfs-5.17-fixes-2


Darrick J. Wong Feb. 5, 2022, 2:51 a.m. UTC
Hi Linus,

Please pull this branch of VFS bugfixes for 5.17-rc3.  I was auditing
the sync_fs code paths recently and noticed that most callers of
->sync_fs ignore its return value (and many implementations never return
nonzero even if the fs is broken!), which means that internal fs errors
and corruption are not passed up to userspace callers of syncfs(2) or
FIFREEZE.  Hence fixing the common code and XFS, and I'll start working
on the ext4/btrfs folks if this is merged.

As usual, I did a test-merge with upstream master as of a few minutes
ago, and didn't see any conflicts.  Please let me know if you encounter
any problems.


The following changes since commit e783362eb54cd99b2cac8b3a9aeac942e6f6ac07:

  Linux 5.17-rc1 (2022-01-23 10:12:53 +0200)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/vfs-5.17-fixes-2

for you to fetch changes up to 2d86293c70750e4331e9616aded33ab6b47c299d:

  xfs: return errors in xfs_fs_sync_fs (2022-01-30 08:59:47 -0800)

Fixes for 5.17-rc3:
 - Fix a bug where callers of ->sync_fs (e.g. sync_filesystem and
   syncfs(2)) ignore the return value.
 - Fix a bug where callers of sync_filesystem (e.g. fs freeze) ignore
   the return value.
 - Fix a bug in XFS where xfs_fs_sync_fs never passed back error

Darrick J. Wong (4):
      vfs: make freeze_super abort when sync_filesystem returns error
      vfs: make sync_filesystem return errors from ->sync_fs
      quota: make dquot_quota_sync return errors from ->sync_fs
      xfs: return errors in xfs_fs_sync_fs

 fs/quota/dquot.c   | 11 ++++++++---
 fs/super.c         | 19 ++++++++++++-------
 fs/sync.c          | 18 ++++++++++++------
 fs/xfs/xfs_super.c |  6 +++++-
 4 files changed, 37 insertions(+), 17 deletions(-)


pr-tracker-bot@kernel.org Feb. 5, 2022, 5:29 p.m. UTC | #1
The pull request you sent on Fri, 4 Feb 2022 18:51:00 -0800:

> git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/vfs-5.17-fixes-2

has been merged into torvalds/linux.git:

Thank you!