| Message ID | 20220307150742.137873-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fs/affs: remove redundant assignment to ch | expand |
On Mon, Mar 07, 2022 at 03:07:42PM +0000, Colin Ian King wrote: > The assignment of ch after subtracting ('a' - 'A') is redundant and > can be removed. Fix this by replacing the -= operator with just - > to remove the assignment. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > fs/affs/namei.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/affs/namei.c b/fs/affs/namei.c > index bcab18956b4f..a1270deba908 100644 > --- a/fs/affs/namei.c > +++ b/fs/affs/namei.c > @@ -19,7 +19,7 @@ typedef int (*toupper_t)(int); > static int > affs_toupper(int ch) > { > - return ch >= 'a' && ch <= 'z' ? ch -= ('a' - 'A') : ch; > + return ch >= 'a' && ch <= 'z' ? ch - ('a' - 'A') : ch; AFFS is in fixes-only mode, I wonder how much this change is affecting anybody, from the user perspective. I'd say not at all, W=1 build is clean and that's something I'd be fine to fix, W=2 and W=3 warnings are from other code.
diff --git a/fs/affs/namei.c b/fs/affs/namei.c index bcab18956b4f..a1270deba908 100644 --- a/fs/affs/namei.c +++ b/fs/affs/namei.c @@ -19,7 +19,7 @@ typedef int (*toupper_t)(int); static int affs_toupper(int ch) { - return ch >= 'a' && ch <= 'z' ? ch -= ('a' - 'A') : ch; + return ch >= 'a' && ch <= 'z' ? ch - ('a' - 'A') : ch; } /* International toupper() for DOS\3 ("international") */
The assignment of ch after subtracting ('a' - 'A') is redundant and can be removed. Fix this by replacing the -= operator with just - to remove the assignment. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- fs/affs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)