| Message ID | 20220518145729.2488102-1-chenxiaosong2@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] fuse: return the more nuanced writeback error on close() | expand |
On Wed, May 18, 2022 at 10:57:29PM +0800, ChenXiaoSong wrote: > + /* return more nuanced writeback errors */ > if (err) > - return err; > + return filemap_check_wb_err(file->f_mapping, 0); > > err = 0; As an aside, what the hell is that err = 0 about? Before or after that patch, that is - "let's make err zero, in case it had somehow magically changed ceased to be so since if (err) bugger_off just above"?
在 2022/5/18 22:51, Al Viro 写道: > On Wed, May 18, 2022 at 10:57:29PM +0800, ChenXiaoSong wrote: > >> + /* return more nuanced writeback errors */ >> if (err) >> - return err; >> + return filemap_check_wb_err(file->f_mapping, 0); >> >> err = 0; > > As an aside, what the hell is that err = 0 about? Before or after > that patch, that is - "let's make err zero, in case it had somehow > magically changed ceased to be so since if (err) bugger_off just above"? > > . > err = 0 is no longer needed after if (err), I will send v2 patch to remove the redundant code.
diff --git a/fs/fuse/file.c b/fs/fuse/file.c index f18d14d5fea1..4a0add7f0a17 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -488,8 +488,9 @@ static int fuse_flush(struct file *file, fl_owner_t id) inode_unlock(inode); err = filemap_check_errors(file->f_mapping); + /* return more nuanced writeback errors */ if (err) - return err; + return filemap_check_wb_err(file->f_mapping, 0); err = 0; if (fm->fc->no_flush)
As filemap_check_errors() only report -EIO or -ENOSPC, we return more nuanced writeback error -(file->f_mapping->wb_err & MAX_ERRNO). filemap_write_and_wait filemap_write_and_wait_range filemap_check_errors -ENOSPC or -EIO filemap_check_wb_err errseq_check return -(file->f_mapping->wb_err & MAX_ERRNO) Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com> --- fs/fuse/file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)