| Message ID | 20220527155036.524743-19-willy@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Begin removing PageError | expand |
On Fri, May 27, 2022 at 04:50:30PM +0100, Matthew Wilcox (Oracle) wrote: > If a buffer is completed with an error, its uptodate flag will be clear, > so the page_uptodate variable will have been set to 0. There's no > need to check PageError here. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/fs/buffer.c b/fs/buffer.c index 898c7f301b1b..c37a9c3bfb2f 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -282,10 +282,10 @@ static void end_buffer_async_read(struct buffer_head *bh, int uptodate) spin_unlock_irqrestore(&first->b_uptodate_lock, flags); /* - * If none of the buffers had errors and they are all - * uptodate then we can set the page uptodate. + * If all of the buffers are uptodate then we can set the page + * uptodate. */ - if (page_uptodate && !PageError(page)) + if (page_uptodate) SetPageUptodate(page); unlock_page(page); return;
If a buffer is completed with an error, its uptodate flag will be clear, so the page_uptodate variable will have been set to 0. There's no need to check PageError here. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- fs/buffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)