| Message ID | 20220625110115.39956-8-Jason@zx2c4.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cleanup llseek and splice | expand |
On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > This is already set by anon_inode_getfile(), since dma_buf_fops has > non-NULL ->llseek, so we don't need to set it here too. > > Suggested-by: Al Viro <viro@zeniv.linux.org.uk> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Christian König <christian.koenig@amd.com> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> I'm assuming this is part of a vfs cleanup and lands through that tree? For that: Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/dma-buf/dma-buf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 32f55640890c..3f08e0b960ec 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -549,7 +549,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info) > goto err_dmabuf; > } > > - file->f_mode |= FMODE_LSEEK; > dmabuf->file = file; > > mutex_init(&dmabuf->lock); > -- > 2.35.1 >
Hi Daniel, On Mon, Jun 27, 2022 at 11:08:32AM +0200, Daniel Vetter wrote: > On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > > This is already set by anon_inode_getfile(), since dma_buf_fops has > > non-NULL ->llseek, so we don't need to set it here too. > > > > Suggested-by: Al Viro <viro@zeniv.linux.org.uk> > > Cc: Sumit Semwal <sumit.semwal@linaro.org> > > Cc: Christian König <christian.koenig@amd.com> > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> > > I'm assuming this is part of a vfs cleanup and lands through that tree? > For that: > > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> With the exception of the first patch (which is more urgent), yes, that is my assumption too. Jason
On Mon, 27 Jun 2022 at 14:38, Daniel Vetter <daniel@ffwll.ch> wrote: > > On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > > This is already set by anon_inode_getfile(), since dma_buf_fops has > > non-NULL ->llseek, so we don't need to set it here too. > > > > Suggested-by: Al Viro <viro@zeniv.linux.org.uk> > > Cc: Sumit Semwal <sumit.semwal@linaro.org> > > Cc: Christian König <christian.koenig@amd.com> > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> > > I'm assuming this is part of a vfs cleanup and lands through that tree? > For that: > > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> FWIW, please feel free to add Acked-by: Sumit Semwal <sumit.semwal@linaro.org> > > > --- > > drivers/dma-buf/dma-buf.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > > index 32f55640890c..3f08e0b960ec 100644 > > --- a/drivers/dma-buf/dma-buf.c > > +++ b/drivers/dma-buf/dma-buf.c > > @@ -549,7 +549,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info) > > goto err_dmabuf; > > } > > > > - file->f_mode |= FMODE_LSEEK; > > dmabuf->file = file; > > > > mutex_init(&dmabuf->lock); > > -- > > 2.35.1 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch Best, Sumit.
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 32f55640890c..3f08e0b960ec 100644 --- a/drivers/dma-buf/dma-buf.c +++ b/drivers/dma-buf/dma-buf.c @@ -549,7 +549,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info) goto err_dmabuf; } - file->f_mode |= FMODE_LSEEK; dmabuf->file = file; mutex_init(&dmabuf->lock);
This is already set by anon_inode_getfile(), since dma_buf_fops has non-NULL ->llseek, so we don't need to set it here too. Suggested-by: Al Viro <viro@zeniv.linux.org.uk> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: Christian König <christian.koenig@amd.com> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> --- drivers/dma-buf/dma-buf.c | 1 - 1 file changed, 1 deletion(-)