| Message ID | 20220831072111.3569680-6-yi.zhang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | buffer: remove ll_rw_block() | expand |
On Wed 31-08-22 15:21:02, Zhang Yi wrote: > ll_rw_block() is not safe for the sync read path because it cannot > guarantee that submitting read IO if the buffer has been locked. We > could get false positive EIO return from zisofs_uncompress_block() if > he buffer has been locked by others. So stop using ll_rw_block(), > switch to sync helper instead. > > Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Looks good to me. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/isofs/compress.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c > index b466172eec25..ac35eddff29c 100644 > --- a/fs/isofs/compress.c > +++ b/fs/isofs/compress.c > @@ -82,7 +82,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start, > return 0; > } > haveblocks = isofs_get_blocks(inode, blocknum, bhs, needblocks); > - ll_rw_block(REQ_OP_READ, haveblocks, bhs); > + bh_read_batch(bhs, haveblocks); > > curbh = 0; > curpage = 0; > -- > 2.31.1 >
diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c index b466172eec25..ac35eddff29c 100644 --- a/fs/isofs/compress.c +++ b/fs/isofs/compress.c @@ -82,7 +82,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start, return 0; } haveblocks = isofs_get_blocks(inode, blocknum, bhs, needblocks); - ll_rw_block(REQ_OP_READ, haveblocks, bhs); + bh_read_batch(bhs, haveblocks); curbh = 0; curpage = 0;
ll_rw_block() is not safe for the sync read path because it cannot guarantee that submitting read IO if the buffer has been locked. We could get false positive EIO return from zisofs_uncompress_block() if he buffer has been locked by others. So stop using ll_rw_block(), switch to sync helper instead. Signed-off-by: Zhang Yi <yi.zhang@huawei.com> --- fs/isofs/compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)