| Message ID | 20221006224212.569555-8-gpiccoli@igalia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Some pstore improvements | expand |
On Thu, Oct 06, 2022 at 07:42:11PM -0300, Guilherme G. Piccoli wrote: > For some reason, the efi-pstore backend name (exposed through the > pstore infrastructure) is hardcoded as "efi", whereas all the other > backends follow a kind of convention in using the module name. > > Let's do it here as well, to make user's life easier (they might > use this info for unloading the module backend, for example). > > Cc: Ard Biesheuvel <ardb@kernel.org> > Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com> Looks fine to me. Ard, if you don't object, I can carry this in the pstore tree.
On Fri, 7 Oct 2022 at 01:16, Kees Cook <keescook@chromium.org> wrote: > > On Thu, Oct 06, 2022 at 07:42:11PM -0300, Guilherme G. Piccoli wrote: > > For some reason, the efi-pstore backend name (exposed through the > > pstore infrastructure) is hardcoded as "efi", whereas all the other > > backends follow a kind of convention in using the module name. > > > > Let's do it here as well, to make user's life easier (they might > > use this info for unloading the module backend, for example). > > > > Cc: Ard Biesheuvel <ardb@kernel.org> > > Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com> > > Looks fine to me. Ard, if you don't object, I can carry this in the > pstore tree. > Acked-by: Ard Biesheuvel <ardb@kernel.org>
On Thu, 6 Oct 2022 19:42:11 -0300, Guilherme G. Piccoli wrote: > For some reason, the efi-pstore backend name (exposed through the > pstore infrastructure) is hardcoded as "efi", whereas all the other > backends follow a kind of convention in using the module name. > > Let's do it here as well, to make user's life easier (they might > use this info for unloading the module backend, for example). > > [...] Applied to for-next/pstore, thanks! [7/8] efi: pstore: Follow convention for the efi-pstore backend name https://git.kernel.org/kees/c/39bae0ee0656
diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c index 3bddc152fcd4..97a9e84840a0 100644 --- a/drivers/firmware/efi/efi-pstore.c +++ b/drivers/firmware/efi/efi-pstore.c @@ -207,7 +207,7 @@ static int efi_pstore_erase(struct pstore_record *record) static struct pstore_info efi_pstore_info = { .owner = THIS_MODULE, - .name = "efi", + .name = KBUILD_MODNAME, .flags = PSTORE_FLAGS_DMESG, .open = efi_pstore_open, .close = efi_pstore_close,
For some reason, the efi-pstore backend name (exposed through the pstore infrastructure) is hardcoded as "efi", whereas all the other backends follow a kind of convention in using the module name. Let's do it here as well, to make user's life easier (they might use this info for unloading the module backend, for example). Cc: Ard Biesheuvel <ardb@kernel.org> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com> --- drivers/firmware/efi/efi-pstore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)