[14/25] fs: port ->permission() to pass mnt_idmap

Convert to struct mnt_idmap.

Last cycle we merged the necessary infrastructure in
256c8aed2b42 ("fs: introduce dedicated idmap type for mounts").
This is just the conversion to struct mnt_idmap.

Currently we still pass around the plain namespace that was attached to a
mount. This is in general pretty convenient but it makes it easy to
conflate namespaces that are relevant on the filesystem with namespaces
that are relevent on the mount level. Especially for non-vfs developers
without detailed knowledge in this area this can be a potential source for
bugs.

Once the conversion to struct mnt_idmap is done all helpers down to the
really low-level helpers will take a struct mnt_idmap argument instead of
two namespace arguments. This way it becomes impossible to conflate the two
eliminating the possibility of any bugs. All of the vfs and all filesystems
only operate on struct mnt_idmap.

Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
---
 Documentation/filesystems/locking.rst     |   2 +-
 Documentation/filesystems/vfs.rst         |   2 +-
 fs/afs/internal.h                         |   2 +-
 fs/afs/security.c                         |   2 +-
 fs/attr.c                                 |   7 +-
 fs/autofs/root.c                          |   6 +-
 fs/bad_inode.c                            |   2 +-
 fs/btrfs/inode.c                          |   4 +-
 fs/btrfs/ioctl.c                          |  51 ++++-----
 fs/cachefiles/xattr.c                     |  10 +-
 fs/ceph/inode.c                           |   4 +-
 fs/ceph/super.h                           |   2 +-
 fs/cifs/cifsfs.c                          |   4 +-
 fs/coda/coda_linux.h                      |   2 +-
 fs/coda/dir.c                             |   2 +-
 fs/coda/pioctl.c                          |   4 +-
 fs/configfs/symlink.c                     |   2 +-
 fs/ecryptfs/inode.c                       |   6 +-
 fs/exec.c                                 |   5 +-
 fs/exportfs/expfs.c                       |   4 +-
 fs/fuse/dir.c                             |   6 +-
 fs/gfs2/file.c                            |   2 +-
 fs/gfs2/inode.c                           |  24 ++---
 fs/gfs2/inode.h                           |   2 +-
 fs/hostfs/hostfs_kern.c                   |   4 +-
 fs/init.c                                 |   4 +-
 fs/inode.c                                |   2 +-
 fs/internal.h                             |   4 +-
 fs/kernfs/inode.c                         |   4 +-
 fs/kernfs/kernfs-internal.h               |   2 +-
 fs/ksmbd/smb2pdu.c                        |  71 +++++++------
 fs/ksmbd/smbacl.c                         |  15 +--
 fs/ksmbd/vfs.c                            | 101 +++++++++---------
 fs/ksmbd/vfs.h                            |  24 ++---
 fs/ksmbd/vfs_cache.c                      |   2 +-
 fs/namei.c                                | 166 +++++++++++++++---------------
 fs/nfs/dir.c                              |   4 +-
 fs/nfsd/nfsfh.c                           |   2 +-
 fs/nfsd/vfs.c                             |  14 +--
 fs/nilfs2/inode.c                         |   4 +-
 fs/nilfs2/nilfs.h                         |   2 +-
 fs/ntfs3/ntfs_fs.h                        |   2 +-
 fs/ntfs3/xattr.c                          |   4 +-
 fs/ocfs2/file.c                           |   4 +-
 fs/ocfs2/file.h                           |   2 +-
 fs/ocfs2/refcounttree.c                   |   4 +-
 fs/open.c                                 |   6 +-
 fs/orangefs/inode.c                       |   4 +-
 fs/orangefs/orangefs-kernel.h             |   2 +-
 fs/overlayfs/export.c                     |   4 +-
 fs/overlayfs/file.c                       |   6 +-
 fs/overlayfs/inode.c                      |  10 +-
 fs/overlayfs/namei.c                      |   6 +-
 fs/overlayfs/overlayfs.h                  |  10 +-
 fs/overlayfs/ovl_entry.h                  |   5 -
 fs/overlayfs/readdir.c                    |   4 +-
 fs/overlayfs/util.c                       |   5 +-
 fs/posix_acl.c                            |   4 +-
 fs/proc/base.c                            |   8 +-
 fs/proc/fd.c                              |   4 +-
 fs/proc/fd.h                              |   2 +-
 fs/proc/proc_sysctl.c                     |   2 +-
 fs/reiserfs/xattr.c                       |   4 +-
 fs/reiserfs/xattr.h                       |   2 +-
 fs/remap_range.c                          |   5 +-
 fs/xattr.c                                |  60 ++++++-----
 include/linux/fs.h                        |  23 +++--
 include/linux/lsm_hook_defs.h             |   2 +-
 include/linux/namei.h                     |   6 +-
 include/linux/nfs_fs.h                    |   2 +-
 include/linux/security.h                  |   8 +-
 include/linux/xattr.h                     |  12 +--
 ipc/mqueue.c                              |   2 +-
 kernel/bpf/inode.c                        |   2 +-
 kernel/cgroup/cgroup.c                    |   2 +-
 security/apparmor/domain.c                |   2 +-
 security/commoncap.c                      |   5 +-
 security/integrity/evm/evm_crypto.c       |   6 +-
 security/integrity/evm/evm_main.c         |   4 +-
 security/integrity/ima/ima_appraise.c     |   2 +-
 security/integrity/ima/ima_template_lib.c |   2 +-
 security/security.c                       |   4 +-
 security/selinux/hooks.c                  |   4 +-
 security/smack/smack_lsm.c                |   4 +-
 84 files changed, 422 insertions(+), 421 deletions(-)

Message ID	20230113-fs-idmapped-mnt_idmap-conversion-v1-14-fc84fa7eba67@kernel.org (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-fsdevel-owner@vger.kernel.org> From: Christian Brauner <brauner@kernel.org> Date: Fri, 13 Jan 2023 12:49:22 +0100 Subject: [PATCH 14/25] fs: port ->permission() to pass mnt_idmap MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230113-fs-idmapped-mnt_idmap-conversion-v1-14-fc84fa7eba67@kernel.org> References: <20230113-fs-idmapped-mnt_idmap-conversion-v1-0-fc84fa7eba67@kernel.org> In-Reply-To: <20230113-fs-idmapped-mnt_idmap-conversion-v1-0-fc84fa7eba67@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: Christian Brauner <brauner@kernel.org>, "Seth Forshee (Digital Ocean)" <sforshee@kernel.org>, Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk> Precedence: bulk
Series	fs: finish conversion to mnt_idmap \| expand [00/25] fs: finish conversion to mnt_idmap [01/25] f2fs: project ids aren't idmapped [02/25] fs: port vfs_*() helpers to struct mnt_idmap [03/25] fs: port ->setattr() to pass mnt_idmap [04/25] fs: port ->getattr() to pass mnt_idmap [05/25] fs: port ->create() to pass mnt_idmap [06/25] fs: port ->symlink() to pass mnt_idmap [07/25] fs: port ->mkdir() to pass mnt_idmap [08/25] fs: port ->mknod() to pass mnt_idmap [09/25] fs: port ->rename() to pass mnt_idmap [10/25] fs: port ->tmpfile() to pass mnt_idmap [11/25] fs: port ->get_acl() to pass mnt_idmap [12/25] fs: port ->set_acl() to pass mnt_idmap [13/25] fs: port ->fileattr_set() to pass mnt_idmap [14/25] fs: port ->permission() to pass mnt_idmap [15/25] fs: port xattr to mnt_idmap [16/25] fs: port acl to mnt_idmap [17/25] fs: port inode_init_owner() to mnt_idmap [18/25] fs: port inode_owner_or_capable() to mnt_idmap [19/25] fs: port privilege checking helpers to mnt_idmap [20/25] quota: port to mnt_idmap [21/25] fs: port i_{g,u}id_{needs_}update() to mnt_idmap [22/25] fs: port i_{g,u}id_into_vfs{g,u}id() to mnt_idmap [23/25] fs: port fs{g,u}id helpers to mnt_idmap [24/25] fs: port vfs{g,u}id helpers to mnt_idmap [25/25] fs: move mnt_idmap

[14/25] fs: port ->permission() to pass mnt_idmap

Commit Message

Patch