| Message ID | 20230309124035.15820-1-frank.li@vivo.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | [v2,1/5] fs: add i_blockmask() | expand |
On Thu, Mar 09, 2023 at 08:40:31PM +0800, Yangtao Li wrote: > Introduce i_blockmask() to simplify code, which replace > (i_blocksize(node) - 1). Like done in commit > 93407472a21b("fs: add i_blocksize()"). > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- Looks good but did you forget to convert fs/remap_range.c by any chance? static int generic_remap_check_len(struct inode *inode_in, struct inode *inode_out, loff_t pos_out, loff_t *len, unsigned int remap_flags) { u64 blkmask = i_blocksize(inode_in) - 1;
diff --git a/include/linux/fs.h b/include/linux/fs.h index c85916e9f7db..17387d465b8b 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -711,6 +711,11 @@ static inline unsigned int i_blocksize(const struct inode *node) return (1 << node->i_blkbits); } +static inline unsigned int i_blockmask(const struct inode *node) +{ + return i_blocksize(node) - 1; +} + static inline int inode_unhashed(struct inode *inode) { return hlist_unhashed(&inode->i_hash);
Introduce i_blockmask() to simplify code, which replace (i_blocksize(node) - 1). Like done in commit 93407472a21b("fs: add i_blocksize()"). Signed-off-by: Yangtao Li <frank.li@vivo.com> --- v2: -convert to i_blockmask() include/linux/fs.h | 5 +++++ 1 file changed, 5 insertions(+)