| Message ID | 20230310231206.3952808-5-mcgrof@kernel.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | misc filesystems: simplify sysctl registration | expand |
Looks good to me, nice little cleanup. Jan On Fri, Mar 10, 2023 at 07:04:07PM -0500, Luis Chamberlain wrote: > There is no need to declare an extra tables to just create directory, > this can be easily be done with a prefix path with register_sysctl(). > > Simplify this registration. > > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> Acked-by: Jan Harkes <jaharkes@cs.cmu.edu > --- > fs/coda/sysctl.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c > index fda3b702b1c5..a247c14aaab7 100644 > --- a/fs/coda/sysctl.c > +++ b/fs/coda/sysctl.c > @@ -39,19 +39,10 @@ static struct ctl_table coda_table[] = { > {} > }; > > -static struct ctl_table fs_table[] = { > - { > - .procname = "coda", > - .mode = 0555, > - .child = coda_table > - }, > - {} > -}; > - > void coda_sysctl_init(void) > { > if ( !fs_table_header ) > - fs_table_header = register_sysctl_table(fs_table); > + fs_table_header = register_sysctl("coda", coda_table); > } > > void coda_sysctl_clean(void) > -- > 2.39.1 > >
diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c index fda3b702b1c5..a247c14aaab7 100644 --- a/fs/coda/sysctl.c +++ b/fs/coda/sysctl.c @@ -39,19 +39,10 @@ static struct ctl_table coda_table[] = { {} }; -static struct ctl_table fs_table[] = { - { - .procname = "coda", - .mode = 0555, - .child = coda_table - }, - {} -}; - void coda_sysctl_init(void) { if ( !fs_table_header ) - fs_table_header = register_sysctl_table(fs_table); + fs_table_header = register_sysctl("coda", coda_table); } void coda_sysctl_clean(void)
There is no need to declare an extra tables to just create directory, this can be easily be done with a prefix path with register_sysctl(). Simplify this registration. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- fs/coda/sysctl.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)