| Message ID | 20230731-mgctime-v1-1-1aa1177841ed@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fs: fix request_mask variable in generic_fillattr kerneldoc comment | expand |
On Mon, Jul 31, 2023 at 06:37:10AM -0400, Jeff Layton wrote: > /** > * generic_fillattr - Fill in the basic attributes from the inode struct > - * @idmap: idmap of the mount the inode was found from > - * @req_mask statx request_mask > - * @inode: Inode to use as the source > - * @stat: Where to fill in the attributes > + * @idmap: idmap of the mount the inode was found from > + * @request_mask statx request_mask Missing the colon after request_mask. > + * @inode: Inode to use as the source > + * @stat: Where to fill in the attributes
On Mon, 31 Jul 2023 06:37:10 -0400, Jeff Layton wrote: > req_mask -> request_mask > > Applied to the vfs.ctime branch of the vfs/vfs.git tree. Patches in the vfs.ctime branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.ctime [1/1 FOLDED] fs: pass the request_mask to generic_fillattr https://git.kernel.org/vfs/vfs/c/0f64b6ec05db
On Mon, Jul 31, 2023 at 01:18:55PM +0100, Matthew Wilcox wrote: > On Mon, Jul 31, 2023 at 06:37:10AM -0400, Jeff Layton wrote: > > /** > > * generic_fillattr - Fill in the basic attributes from the inode struct > > - * @idmap: idmap of the mount the inode was found from > > - * @req_mask statx request_mask > > - * @inode: Inode to use as the source > > - * @stat: Where to fill in the attributes > > + * @idmap: idmap of the mount the inode was found from > > + * @request_mask statx request_mask > > Missing the colon after request_mask. Fixed in-tree, thanks!
On Mon, Jul 31, 2023 at 02:28:49PM +0200, Christian Brauner wrote: > On Mon, Jul 31, 2023 at 01:18:55PM +0100, Matthew Wilcox wrote: > > On Mon, Jul 31, 2023 at 06:37:10AM -0400, Jeff Layton wrote: > > > /** > > > * generic_fillattr - Fill in the basic attributes from the inode struct > > > - * @idmap: idmap of the mount the inode was found from > > > - * @req_mask statx request_mask > > > - * @inode: Inode to use as the source > > > - * @stat: Where to fill in the attributes > > > + * @idmap: idmap of the mount the inode was found from > > > + * @request_mask statx request_mask > > > > Missing the colon after request_mask. > > Fixed in-tree, thanks! FWIW, a W=1 build will catch this: ../mm/filemap.c:254: warning: Function parameter or member 'folio' not described in 'filemap_remove_folio' (after having deliberately removed the colon on that line)
On Mon, Jul 31, 2023 at 01:32:04PM +0100, Matthew Wilcox wrote: > On Mon, Jul 31, 2023 at 02:28:49PM +0200, Christian Brauner wrote: > > On Mon, Jul 31, 2023 at 01:18:55PM +0100, Matthew Wilcox wrote: > > > On Mon, Jul 31, 2023 at 06:37:10AM -0400, Jeff Layton wrote: > > > > /** > > > > * generic_fillattr - Fill in the basic attributes from the inode struct > > > > - * @idmap: idmap of the mount the inode was found from > > > > - * @req_mask statx request_mask > > > > - * @inode: Inode to use as the source > > > > - * @stat: Where to fill in the attributes > > > > + * @idmap: idmap of the mount the inode was found from > > > > + * @request_mask statx request_mask > > > > > > Missing the colon after request_mask. > > > > Fixed in-tree, thanks! > > FWIW, a W=1 build will catch this: > > ../mm/filemap.c:254: warning: Function parameter or member 'folio' not described in 'filemap_remove_folio' > > (after having deliberately removed the colon on that line) Thanks! I often only do W=1 builds by hand on specific files because otherwise there's such a wall of warnings that it's hard to see what's going on.
diff --git a/fs/stat.c b/fs/stat.c index 51effd1c2bc2..592b62d577b6 100644 --- a/fs/stat.c +++ b/fs/stat.c @@ -59,10 +59,10 @@ EXPORT_SYMBOL(fill_mg_cmtime); /** * generic_fillattr - Fill in the basic attributes from the inode struct - * @idmap: idmap of the mount the inode was found from - * @req_mask statx request_mask - * @inode: Inode to use as the source - * @stat: Where to fill in the attributes + * @idmap: idmap of the mount the inode was found from + * @request_mask statx request_mask + * @inode: Inode to use as the source + * @stat: Where to fill in the attributes * * Fill in the basic attributes in the kstat structure from data that's to be * found on the VFS inode structure. This is the default if no getattr inode
req_mask -> request_mask Fixes: 0a6ab6dc6958 ("fs: pass the request_mask to generic_fillattr") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/stat.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- base-commit: dec705a2d44a306ca3502dd34ccfe8d8ffd79537 change-id: 20230728-mgctime-5e0ec0e89b04 Best regards,