[v2,20/89] bcachefs: convert to new timestamp accessors

Message ID	20231004185347.80880-18-jlayton@kernel.org (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-fsdevel-owner@vger.kernel.org> From: Jeff Layton <jlayton@kernel.org> To: Alexander Viro <viro@zeniv.linux.org.uk>, Christian Brauner <brauner@kernel.org>, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Brian Foster <bfoster@redhat.com>, linux-bcachefs@vger.kernel.org Subject: [PATCH v2 20/89] bcachefs: convert to new timestamp accessors Date: Wed, 4 Oct 2023 14:52:05 -0400 Message-ID: <20231004185347.80880-18-jlayton@kernel.org> In-Reply-To: <20231004185347.80880-1-jlayton@kernel.org> References: <20231004185221.80802-1-jlayton@kernel.org> <20231004185347.80880-1-jlayton@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	fs: new accessor methods for inode atime and mtime \| expand [v2,00/89] fs: new accessor methods for inode atime and mtime [v2,03/89] spufs: convert to new timestamp accessors [v2,04/89] hypfs: convert to new timestamp accessors [v2,05/89] android: convert to new timestamp accessors [v2,06/89] char: convert to new timestamp accessors [v2,07/89] qib: convert to new timestamp accessors [v2,08/89] ibmasm: convert to new timestamp accessors [v2,09/89] misc: convert to new timestamp accessors [v2,10/89] x86: convert to new timestamp accessors [v2,11/89] tty: convert to new timestamp accessors [v2,12/89] function: convert to new timestamp accessors [v2,13/89] legacy: convert to new timestamp accessors [v2,14/89] usb: convert to new timestamp accessors [v2,15/89] 9p: convert to new timestamp accessors [v2,16/89] adfs: convert to new timestamp accessors [v2,17/89] affs: convert to new timestamp accessors [v2,18/89] afs: convert to new timestamp accessors [v2,19/89] autofs: convert to new timestamp accessors [v2,20/89] bcachefs: convert to new timestamp accessors [v2,21/89] befs: convert to new timestamp accessors [v2,22/89] bfs: convert to new timestamp accessors [v2,23/89] btrfs: convert to new timestamp accessors [v2,24/89] ceph: convert to new timestamp accessors [v2,25/89] coda: convert to new timestamp accessors [v2,26/89] configfs: convert to new timestamp accessors [v2,27/89] cramfs: convert to new timestamp accessors [v2,28/89] debugfs: convert to new timestamp accessors [v2,29/89] devpts: convert to new timestamp accessors [v2,30/89] efivarfs: convert to new timestamp accessors [v2,31/89] efs: convert to new timestamp accessors [v2,32/89] erofs: convert to new timestamp accessors [v2,33/89] exfat: convert to new timestamp accessors [v2,34/89] ext2: convert to new timestamp accessors [v2,35/89] ext4: convert to new timestamp accessors [v2,36/89] f2fs: convert to new timestamp accessors [v2,37/89] fat: convert to new timestamp accessors [v2,38/89] freevxfs: convert to new timestamp accessors [v2,39/89] fuse: convert to new timestamp accessors [v2,40/89] gfs2: convert to new timestamp accessors [v2,41/89] hfs: convert to new timestamp accessors [v2,42/89] hfsplus: convert to new timestamp accessors [v2,43/89] hostfs: convert to new timestamp accessors [v2,44/89] hpfs: convert to new timestamp accessors [v2,45/89] hugetlbfs: convert to new timestamp accessors [v2,46/89] isofs: convert to new timestamp accessors [v2,47/89] jffs2: convert to new timestamp accessors [v2,48/89] jfs: convert to new timestamp accessors [v2,49/89] kernfs: convert to new timestamp accessors [v2,50/89] minix: convert to new timestamp accessors [v2,51/89] nfs: convert to new timestamp accessors [v2,52/89] nfsd: convert to new timestamp accessors [v2,01/89] fs: new accessor methods for atime and mtime [v2,02/89] fs: convert core infrastructure to new timestamp accessors [v2,53/89] nilfs2: convert to new timestamp accessors [v2,54/89] ntfs: convert to new timestamp accessors [v2,55/89] ntfs3: convert to new timestamp accessors [v2,56/89] ocfs2: convert to new timestamp accessors [v2,57/89] omfs: convert to new timestamp accessors [v2,58/89] openpromfs: convert to new timestamp accessors [v2,59/89] orangefs: convert to new timestamp accessors [v2,60/89] overlayfs: convert to new timestamp accessors [v2,61/89] proc: convert to new timestamp accessors [v2,62/89] pstore: convert to new timestamp accessors [v2,63/89] qnx4: convert to new timestamp accessors [v2,64/89] qnx6: convert to new timestamp accessors [v2,65/89] ramfs: convert to new timestamp accessors [v2,66/89] reiserfs: convert to new timestamp accessors [v2,67/89] romfs: convert to new timestamp accessors [v2,68/89] client: convert to new timestamp accessors [v2,69/89] server: convert to new timestamp accessors [v2,70/89] squashfs: convert to new timestamp accessors [v2,71/89] sysv: convert to new timestamp accessors [v2,72/89] tracefs: convert to new timestamp accessors [v2,73/89] ubifs: convert to new timestamp accessors [v2,74/89] udf: convert to new timestamp accessors [v2,75/89] ufs: convert to new timestamp accessors [v2,76/89] vboxsf: convert to new timestamp accessors [v2,77/89] xfs: convert to new timestamp accessors [v2,78/89] zonefs: convert to new timestamp accessors [v2,79/89] linux: convert to new timestamp accessors [v2,80/89] ipc: convert to new timestamp accessors [v2,81/89] bpf: convert to new timestamp accessors [v2,82/89] mm: convert to new timestamp accessors [v2,83/89] sunrpc: convert to new timestamp accessors [v2,84/89] apparmor: convert to new timestamp accessors [v2,85/89] selinux: convert to new timestamp accessors [v2,86/89] security: convert to new timestamp accessors [v2,87/89] fs: rename inode i_atime and i_mtime fields [v2,88/89] fs: switch timespec64 fields in inode to discrete integers [v2,89/89] fs: move i_generation into new hole created after timestamp conversion

Message ID

20231004185347.80880-18-jlayton@kernel.org (mailing list archive)

State

New, archived

Headers

From: Jeff Layton <jlayton@kernel.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Brian Foster <bfoster@redhat.com>, linux-bcachefs@vger.kernel.org
Subject: [PATCH v2 20/89] bcachefs: convert to new timestamp accessors
Date: Wed,  4 Oct 2023 14:52:05 -0400
Message-ID: <20231004185347.80880-18-jlayton@kernel.org>
In-Reply-To: <20231004185347.80880-1-jlayton@kernel.org>
References: <20231004185221.80802-1-jlayton@kernel.org>
 <20231004185347.80880-1-jlayton@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

fs: new accessor methods for inode atime and mtime | expand

Comments

Brian Foster Oct. 5, 2023, 12:08 p.m. UTC | #1

On Wed, Oct 04, 2023 at 02:52:05PM -0400, Jeff Layton wrote:
> Convert to using the new inode timestamp accessor functions.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---

Acked-by: Brian Foster <bfoster@redhat.com>

>  fs/bcachefs/fs.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c
> index 09137a20449b..1fbaad27d07b 100644
> --- a/fs/bcachefs/fs.c
> +++ b/fs/bcachefs/fs.c
> @@ -66,9 +66,9 @@ void bch2_inode_update_after_write(struct btree_trans *trans,
>  	inode->v.i_mode	= bi->bi_mode;
>  
>  	if (fields & ATTR_ATIME)
> -		inode->v.i_atime = bch2_time_to_timespec(c, bi->bi_atime);
> +		inode_set_atime_to_ts(&inode->v, bch2_time_to_timespec(c, bi->bi_atime));
>  	if (fields & ATTR_MTIME)
> -		inode->v.i_mtime = bch2_time_to_timespec(c, bi->bi_mtime);
> +		inode_set_mtime_to_ts(&inode->v, bch2_time_to_timespec(c, bi->bi_mtime));
>  	if (fields & ATTR_CTIME)
>  		inode_set_ctime_to_ts(&inode->v, bch2_time_to_timespec(c, bi->bi_ctime));
>  
> @@ -753,8 +753,8 @@ static int bch2_getattr(struct mnt_idmap *idmap,
>  	stat->gid	= inode->v.i_gid;
>  	stat->rdev	= inode->v.i_rdev;
>  	stat->size	= i_size_read(&inode->v);
> -	stat->atime	= inode->v.i_atime;
> -	stat->mtime	= inode->v.i_mtime;
> +	stat->atime	= inode_get_atime(&inode->v);
> +	stat->mtime	= inode_get_mtime(&inode->v);
>  	stat->ctime	= inode_get_ctime(&inode->v);
>  	stat->blksize	= block_bytes(c);
>  	stat->blocks	= inode->v.i_blocks;
> @@ -1418,8 +1418,8 @@ static int inode_update_times_fn(struct btree_trans *trans,
>  {
>  	struct bch_fs *c = inode->v.i_sb->s_fs_info;
>  
> -	bi->bi_atime	= timespec_to_bch2_time(c, inode->v.i_atime);
> -	bi->bi_mtime	= timespec_to_bch2_time(c, inode->v.i_mtime);
> +	bi->bi_atime	= timespec_to_bch2_time(c, inode_get_atime(&inode->v));
> +	bi->bi_mtime	= timespec_to_bch2_time(c, inode_get_mtime(&inode->v));
>  	bi->bi_ctime	= timespec_to_bch2_time(c, inode_get_ctime(&inode->v));
>  
>  	return 0;
> -- 
> 2.41.0
>

diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c
index 09137a20449b..1fbaad27d07b 100644
--- a/fs/bcachefs/fs.c
+++ b/fs/bcachefs/fs.c
@@ -66,9 +66,9 @@  void bch2_inode_update_after_write(struct btree_trans *trans,
 	inode->v.i_mode	= bi->bi_mode;
 
 	if (fields & ATTR_ATIME)
-		inode->v.i_atime = bch2_time_to_timespec(c, bi->bi_atime);
+		inode_set_atime_to_ts(&inode->v, bch2_time_to_timespec(c, bi->bi_atime));
 	if (fields & ATTR_MTIME)
-		inode->v.i_mtime = bch2_time_to_timespec(c, bi->bi_mtime);
+		inode_set_mtime_to_ts(&inode->v, bch2_time_to_timespec(c, bi->bi_mtime));
 	if (fields & ATTR_CTIME)
 		inode_set_ctime_to_ts(&inode->v, bch2_time_to_timespec(c, bi->bi_ctime));
 
@@ -753,8 +753,8 @@  static int bch2_getattr(struct mnt_idmap *idmap,
 	stat->gid	= inode->v.i_gid;
 	stat->rdev	= inode->v.i_rdev;
 	stat->size	= i_size_read(&inode->v);
-	stat->atime	= inode->v.i_atime;
-	stat->mtime	= inode->v.i_mtime;
+	stat->atime	= inode_get_atime(&inode->v);
+	stat->mtime	= inode_get_mtime(&inode->v);
 	stat->ctime	= inode_get_ctime(&inode->v);
 	stat->blksize	= block_bytes(c);
 	stat->blocks	= inode->v.i_blocks;
@@ -1418,8 +1418,8 @@  static int inode_update_times_fn(struct btree_trans *trans,
 {
 	struct bch_fs *c = inode->v.i_sb->s_fs_info;
 
-	bi->bi_atime	= timespec_to_bch2_time(c, inode->v.i_atime);
-	bi->bi_mtime	= timespec_to_bch2_time(c, inode->v.i_mtime);
+	bi->bi_atime	= timespec_to_bch2_time(c, inode_get_atime(&inode->v));
+	bi->bi_mtime	= timespec_to_bch2_time(c, inode_get_mtime(&inode->v));
 	bi->bi_ctime	= timespec_to_bch2_time(c, inode_get_ctime(&inode->v));
 
 	return 0;

[v2,20/89] bcachefs: convert to new timestamp accessors

Commit Message

Comments

Patch