MAINTAINERS: create an entry for exportfs

Commit Message

Amir Goldstein Oct. 26, 2023, 8:55 p.m. UTC

Split the exportfs entry from the nfsd entry and add myself as reviewer.

Suggested-by: Chuck Lever <[e-mail]>
Acked-by: Chuck Lever <[e-mail]>
Acked-by: Jeff Layton <[e-mail]>
Signed-off-by: Amir Goldstein <[e-mail]>
---

Christian,

Chuck has suggested that I send this patch to you.
If you prefer that Chuck merges this patch though his tree
that's fine by me.

Thanks,
Amir.

 MAINTAINERS | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

Comments

Christoph Hellwig Oct. 27, 2023, 6:08 a.m. UTC | #1

On Thu, Oct 26, 2023 at 11:55:53PM +0300, Amir Goldstein wrote:
> Split the exportfs entry from the nfsd entry and add myself as reviewer.

I think exportfs is by now very much VFS code.

Amir Goldstein Oct. 27, 2023, 6:35 a.m. UTC | #2

On Fri, Oct 27, 2023 at 9:08 AM Christoph Hellwig <[e-mail]> wrote:
>
> On Thu, Oct 26, 2023 at 11:55:53PM +0300, Amir Goldstein wrote:
> > Split the exportfs entry from the nfsd entry and add myself as reviewer.
>
> I think exportfs is by now very much VFS code.
>

Yes, that's the idea of making it a vfs sub-entry in MAINTAINERS.

Is that an ACK? or did you mean that something needs to change
in the patch?

Thanks,
Amir.

Christoph Hellwig Oct. 27, 2023, 7:30 a.m. UTC | #3

On Fri, Oct 27, 2023 at 09:35:29AM +0300, Amir Goldstein wrote:
> On Fri, Oct 27, 2023 at 9:08 AM Christoph Hellwig <[e-mail]> wrote:
> >
> > On Thu, Oct 26, 2023 at 11:55:53PM +0300, Amir Goldstein wrote:
> > > Split the exportfs entry from the nfsd entry and add myself as reviewer.
> >
> > I think exportfs is by now very much VFS code.
> >
> 
> Yes, that's the idea of making it a vfs sub-entry in MAINTAINERS.
> 
> Is that an ACK? or did you mean that something needs to change
> in the patch?

I as mostly thinking of dropping the diretory and the separate entry.
That would also go along with your patch of making it a bool.

But if you feel strongly about that we can add you as an extra reviewer
for it :)

Amir Goldstein Oct. 27, 2023, 12:55 p.m. UTC | #4

On Fri, Oct 27, 2023 at 10:30 AM Christoph Hellwig <[e-mail]> wrote:
>
> On Fri, Oct 27, 2023 at 09:35:29AM +0300, Amir Goldstein wrote:
> > On Fri, Oct 27, 2023 at 9:08 AM Christoph Hellwig <[e-mail]> wrote:
> > >
> > > On Thu, Oct 26, 2023 at 11:55:53PM +0300, Amir Goldstein wrote:
> > > > Split the exportfs entry from the nfsd entry and add myself as reviewer.
> > >
> > > I think exportfs is by now very much VFS code.
> > >
> >
> > Yes, that's the idea of making it a vfs sub-entry in MAINTAINERS.
> >
> > Is that an ACK? or did you mean that something needs to change
> > in the patch?
>
> I as mostly thinking of dropping the diretory and the separate entry.
> That would also go along with your patch of making it a bool.
>
> But if you feel strongly about that we can add you as an extra reviewer
> for it :)

I don't have a strong opinion about this.
I am submitting this patch on behalf of the current export
maintainers who requested to stay as maintainers of fs/exportfs
and offered that I join as a reviewer of fs/exportfs.
I cannot join as a reviewer of nfsd, hence this needs an entry.

Thanks,
Amir.

Christian Brauner Oct. 27, 2023, 1:10 p.m. UTC | #5

On Thu, 26 Oct 2023 23:55:53 +0300, Amir Goldstein wrote:
> Split the exportfs entry from the nfsd entry and add myself as reviewer.
> 
> 

Looks useful to clarify this. I've create vfs-6.7.* tags yesterday I
plan on sending this one either at the end of next week or in week 2
together with other possible fixes.

---

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] MAINTAINERS: create an entry for exportfs
      https://git.kernel.org/vfs/vfs/c/7723a9a55be9

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 2894f0777537..a194e6b0bcd1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8051,6 +8051,18 @@  F:	include/linux/fs_types.h
 F:	include/uapi/linux/fs.h
 F:	include/uapi/linux/openat2.h
 
+FILESYSTEMS [EXPORTFS]
+M:	Chuck Lever <[e-mail]>
+M:	Jeff Layton <[e-mail]>
+R:	Amir Goldstein <[e-mail]>
+L:	[e-mail]
+L:	[e-mail]
+S:	Supported
+F:	Documentation/filesystems/nfs/exporting.rst
+F:	fs/exportfs/
+F:	fs/fhandle.c
+F:	include/linux/exportfs.h
+
 FINTEK F75375S HARDWARE MONITOR AND FAN CONTROLLER DRIVER
 M:	Riku Voipio <[e-mail]>
 L:	[e-mail]
@@ -11420,7 +11432,6 @@  S:	Supported
 W:	http://nfs.sourceforge.net/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
 F:	Documentation/filesystems/nfs/
-F:	fs/exportfs/
 F:	fs/lockd/
 F:	fs/nfs_common/
 F:	fs/nfsd/