diff mbox series

[v2,34/40] afs: Fix comment in afs_do_lookup()

Message ID	20231213135003.367397-35-dhowells@redhat.com (mailing list archive)
State	New
Headers	show Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RRBSVNas" From: David Howells <dhowells@redhat.com> To: Marc Dionne <marc.dionne@auristor.com> Cc: David Howells <dhowells@redhat.com>, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 34/40] afs: Fix comment in afs_do_lookup() Date: Wed, 13 Dec 2023 13:49:56 +0000 Message-ID: <20231213135003.367397-35-dhowells@redhat.com> In-Reply-To: <20231213135003.367397-1-dhowells@redhat.com> References: <20231213135003.367397-1-dhowells@redhat.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	afs: Fix probe handling, server rotation and RO volume callback handling \| expand [v2,00/40] afs: Fix probe handling, server rotation and RO volume callback handling [v2,01/40] afs: fix the usage of read_seqbegin_or_lock() in afs_lookup_volume_rcu() [v2,02/40] afs: fix the usage of read_seqbegin_or_lock() in afs_find_server*() [v2,03/40] afs: use read_seqbegin() in afs_check_validity() and afs_getattr() [v2,04/40] rxrpc_find_service_conn_rcu: fix the usage of read_seqbegin_or_lock() [v2,05/40] afs: Remove whitespace before most ')' from the trace header [v2,06/40] afs: Automatically generate trace tag enums [v2,07/40] afs: Add comments on abort handling [v2,08/40] afs: Turn the afs_addr_list address array into an array of structs [v2,09/40] rxrpc, afs: Allow afs to pin rxrpc_peer objects [v2,10/40] afs: Don't skip server addresses for which we didn't get an RTT reading [v2,11/40] afs: Rename addr_list::failed to probe_failed [v2,12/40] afs: Handle the VIO and UAEIO aborts explicitly [v2,13/40] afs: Use op->nr_iterations=-1 to indicate to begin fileserver iteration [v2,14/40] afs: Wrap most op->error accesses with inline funcs [v2,15/40] afs: Don't put afs_call in afs_wait_for_call_to_complete() [v2,16/40] afs: Simplify error handling [v2,17/40] afs: Add a tracepoint for struct afs_addr_list [v2,18/40] afs: Rename some fields [v2,19/40] afs: Use peer + service_id as call address [v2,20/40] afs: Fold the afs_addr_cursor struct in [v2,21/40] rxrpc: Create a procfile to display outstanding client conn bundles [v2,22/40] afs: Add some more info to /proc/net/afs/servers [v2,23/40] afs: Remove the unimplemented afs_cmp_addr_list() [v2,24/40] afs: Provide a way to configure address priorities [v2,25/40] afs: Mark address lists with configured priorities [v2,26/40] afs: Dispatch fileserver probes in priority order [v2,27/40] afs: Dispatch vlserver probes in priority order [v2,28/40] afs: Keep a record of the current fileserver endpoint state [v2,29/40] afs: Combine the endpoint state bools into a bitmask [v2,30/40] afs: Make it possible to find the volumes that are using a server [v2,31/40] afs: Defer volume record destruction to a workqueue [v2,32/40] afs: Move the vnode/volume validity checking code into its own file [v2,33/40] afs: Apply server breaks to mmap'd files in the call processor [v2,34/40] afs: Fix comment in afs_do_lookup() [v2,35/40] afs: Don't leave DONTUSE/NEWREPSITE servers out of server list [v2,36/40] afs: Parse the VolSync record in the reply of a number of RPC ops [v2,37/40] afs: Overhaul invalidation handling to better support RO volumes [v2,38/40] afs: Fix fileserver rotation [v2,39/40] afs: Fix offline and busy message emission [v2,40/40] afs: trace: Log afs_make_call(), including server address

Commit Message

David Howells Dec. 13, 2023, 1:49 p.m. UTC

Fix the comment in afs_do_lookup() that says that slot 0 is used for the
fid being looked up and slot 1 is used for the directory.  It's actually
done the other way round.

Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
---
 fs/afs/dir.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index ecb889a269fb..e232f713ece1 100644
--- a/fs/afs/dir.c
+++ b/fs/afs/dir.c
@@ -807,8 +807,8 @@  static struct inode *afs_do_lookup(struct inode *dir, struct dentry *dentry,
 		cookie->fids[i].vid = dvnode->fid.vid;
 	cookie->ctx.actor = afs_lookup_filldir;
 	cookie->name = dentry->d_name;
-	cookie->nr_fids = 2; /* slot 0 is saved for the fid we actually want
-			      * and slot 1 for the directory */
+	cookie->nr_fids = 2; /* slot 1 is saved for the fid we actually want
+			      * and slot 0 for the directory */
 
 	if (!afs_server_supports_ibulk(dvnode))
 		cookie->one_only = true;