| Message ID | 20231220053013.GQ1674809@ZenIV (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | PATCH 01/22] hostfs: use d_splice_alias() calling conventions to simplify failure exits | expand |
On Wed, Dec 20, 2023 at 05:30:13AM +0000, Al Viro wrote: > That went into the tree back in 2005; the comment used to be true for > predecessor of simple_fill_super() that happened to live in nfsd; that one > didn't take care to skip the array entries with NULL ->name, so it could > not tolerate any gaps. That had been fixed in 2003 when nfsd_fill_super() > had been abstracted into simple_fill_super(); if Neil's patch lived out > of tree during that time, he probably replaced the name of function when > rebasing it and didn't notice that restriction in question was no longer > there. > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Acked-by: Chuck Lever <chuck.lever@oracle.com> > --- > fs/nfsd/nfsctl.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c > index 3e15b72f421d..26a25e40c451 100644 > --- a/fs/nfsd/nfsctl.c > +++ b/fs/nfsd/nfsctl.c > @@ -48,10 +48,6 @@ enum { > NFSD_MaxBlkSize, > NFSD_MaxConnections, > NFSD_Filecache, > - /* > - * The below MUST come last. Otherwise we leave a hole in nfsd_files[] > - * with !CONFIG_NFSD_V4 and simple_fill_super() goes oops > - */ > #ifdef CONFIG_NFSD_V4 > NFSD_Leasetime, > NFSD_Gracetime, > -- > 2.39.2 > >
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 3e15b72f421d..26a25e40c451 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -48,10 +48,6 @@ enum { NFSD_MaxBlkSize, NFSD_MaxConnections, NFSD_Filecache, - /* - * The below MUST come last. Otherwise we leave a hole in nfsd_files[] - * with !CONFIG_NFSD_V4 and simple_fill_super() goes oops - */ #ifdef CONFIG_NFSD_V4 NFSD_Leasetime, NFSD_Gracetime,
That went into the tree back in 2005; the comment used to be true for predecessor of simple_fill_super() that happened to live in nfsd; that one didn't take care to skip the array entries with NULL ->name, so it could not tolerate any gaps. That had been fixed in 2003 when nfsd_fill_super() had been abstracted into simple_fill_super(); if Neil's patch lived out of tree during that time, he probably replaced the name of function when rebasing it and didn't notice that restriction in question was no longer there. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- fs/nfsd/nfsctl.c | 4 ---- 1 file changed, 4 deletions(-)