| Message ID | 20240210050606.9182-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fs/hfsplus: use better @opf description | expand |
On 2/9/24 21:06, Randy Dunlap wrote: > diff -- a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c > --- a/fs/hfsplus/wrapper.c > +++ b/fs/hfsplus/wrapper.c > @@ -30,7 +30,7 @@ struct hfsplus_wd { > * @sector: block to read or write, for blocks of HFSPLUS_SECTOR_SIZE bytes > * @buf: buffer for I/O > * @data: output pointer for location of requested data > - * @opf: request op flags > + * @opf: I/O operation type and flags > * > * The unit of I/O is hfsplus_min_io_size(sb), which may be bigger than > * HFSPLUS_SECTOR_SIZE, and @buf must be sized accordingly. On reads Thanks! Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On Fri, 09 Feb 2024 21:06:06 -0800, Randy Dunlap wrote: > Use a more descriptive explanation of the @opf function parameter, > more in line with <linux/blk_types.h>. > > Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] fs/hfsplus: use better @opf description https://git.kernel.org/vfs/vfs/c/c4effe1da938
diff -- a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c --- a/fs/hfsplus/wrapper.c +++ b/fs/hfsplus/wrapper.c @@ -30,7 +30,7 @@ struct hfsplus_wd { * @sector: block to read or write, for blocks of HFSPLUS_SECTOR_SIZE bytes * @buf: buffer for I/O * @data: output pointer for location of requested data - * @opf: request op flags + * @opf: I/O operation type and flags * * The unit of I/O is hfsplus_min_io_size(sb), which may be bigger than * HFSPLUS_SECTOR_SIZE, and @buf must be sized accordingly. On reads
Use a more descriptive explanation of the @opf function parameter, more in line with <linux/blk_types.h>. Fixes: 02105f18a26c ("fs/hfsplus: wrapper.c: fix kernel-doc warnings") Suggested-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Alexander Viro <viro@zeniv.linux.org.uk> Cc: Christian Brauner <brauner@kernel.org> Cc: Jens Axboe <axboe@kernel.dk> --- fs/hfsplus/wrapper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)