| Message ID | 20240227155756.420944-1-stefanha@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | virtiofs: drop __exit from virtio_fs_sysfs_exit() | expand |
On 2/27/24 07:57, Stefan Hajnoczi wrote: > virtio_fs_sysfs_exit() is called by: > - static int __init virtio_fs_init(void) > - static void __exit virtio_fs_exit(void) > > Remove __exit from virtio_fs_sysfs_exit() since virtio_fs_init() is not > an __exit function. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202402270649.GYjNX0yw-lkp@intel.com/ > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Thanks. > --- > fs/fuse/virtio_fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c > index 62a44603740c..948b49c2460d 100644 > --- a/fs/fuse/virtio_fs.c > +++ b/fs/fuse/virtio_fs.c > @@ -1588,7 +1588,7 @@ static int __init virtio_fs_sysfs_init(void) > return 0; > } > > -static void __exit virtio_fs_sysfs_exit(void) > +static void virtio_fs_sysfs_exit(void) > { > kset_unregister(virtio_fs_kset); > virtio_fs_kset = NULL;
On Tue, 27 Feb 2024 at 23:31, Randy Dunlap <rdunlap@infradead.org> wrote: > > > > On 2/27/24 07:57, Stefan Hajnoczi wrote: > > virtio_fs_sysfs_exit() is called by: > > - static int __init virtio_fs_init(void) > > - static void __exit virtio_fs_exit(void) > > > > Remove __exit from virtio_fs_sysfs_exit() since virtio_fs_init() is not > > an __exit function. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202402270649.GYjNX0yw-lkp@intel.com/ > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > > > Reviewed-by: Randy Dunlap <rdunlap@infradead.org> > Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Applied, thanks. Miklos
diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c index 62a44603740c..948b49c2460d 100644 --- a/fs/fuse/virtio_fs.c +++ b/fs/fuse/virtio_fs.c @@ -1588,7 +1588,7 @@ static int __init virtio_fs_sysfs_init(void) return 0; } -static void __exit virtio_fs_sysfs_exit(void) +static void virtio_fs_sysfs_exit(void) { kset_unregister(virtio_fs_kset); virtio_fs_kset = NULL;
virtio_fs_sysfs_exit() is called by: - static int __init virtio_fs_init(void) - static void __exit virtio_fs_exit(void) Remove __exit from virtio_fs_sysfs_exit() since virtio_fs_init() is not an __exit function. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202402270649.GYjNX0yw-lkp@intel.com/ Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- fs/fuse/virtio_fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)