| Message ID | 20240410162221.292485-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [next] fs/direct-io: remove redundant assignment to variable retval | expand |
On Wed 10-04-24 17:22:21, Colin Ian King wrote: > The variable retval is being assigned a value that is not being read, > it is being re-assigned later on in the function. The assignment > is redundant and can be removed. > > Cleans up clang scan build warning: > fs/direct-io.c:1220:2: warning: Value stored to 'retval' is never > read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Indeed it's assigned a few lines below. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/direct-io.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/direct-io.c b/fs/direct-io.c > index 62c97ff9e852..b0aafe640fa4 100644 > --- a/fs/direct-io.c > +++ b/fs/direct-io.c > @@ -1217,7 +1217,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode, > */ > inode_dio_begin(inode); > > - retval = 0; > sdio.blkbits = blkbits; > sdio.blkfactor = i_blkbits - blkbits; > sdio.block_in_file = offset >> blkbits; > -- > 2.39.2 >
On Wed, 10 Apr 2024 17:22:21 +0100, Colin Ian King wrote: > The variable retval is being assigned a value that is not being read, > it is being re-assigned later on in the function. The assignment > is redundant and can be removed. > > Cleans up clang scan build warning: > fs/direct-io.c:1220:2: warning: Value stored to 'retval' is never > read [deadcode.DeadStores] > > [...] Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] fs/direct-io: remove redundant assignment to variable retval https://git.kernel.org/vfs/vfs/c/fd0a133ef6ed
diff --git a/fs/direct-io.c b/fs/direct-io.c index 62c97ff9e852..b0aafe640fa4 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -1217,7 +1217,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode, */ inode_dio_begin(inode); - retval = 0; sdio.blkbits = blkbits; sdio.blkfactor = i_blkbits - blkbits; sdio.block_in_file = offset >> blkbits;
The variable retval is being assigned a value that is not being read, it is being re-assigned later on in the function. The assignment is redundant and can be removed. Cleans up clang scan build warning: fs/direct-io.c:1220:2: warning: Value stored to 'retval' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- fs/direct-io.c | 1 - 1 file changed, 1 deletion(-)