diff mbox series

[17/30] ntfs3: Remove calls to set/clear the error flag

Message ID	20240420025029.2166544-18-willy@infradead.org (mailing list archive)
State	New
Headers	show Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64CA979DE; Sat, 20 Apr 2024 02:50:57 +0000 (UTC) From: "Matthew Wilcox (Oracle)" <willy@infradead.org> To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>, Konstantin Komarov <almaz.alexandrovich@paragon-software.com>, ntfs3@lists.linux.dev Subject: [PATCH 17/30] ntfs3: Remove calls to set/clear the error flag Date: Sat, 20 Apr 2024 03:50:12 +0100 Message-ID: <20240420025029.2166544-18-willy@infradead.org> In-Reply-To: <20240420025029.2166544-1-willy@infradead.org> References: <20240420025029.2166544-1-willy@infradead.org> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	Remove PG_error flag \| expand [00/30] Remove PG_error flag [01/30] btrfs: Use a folio in wait_dev_supers() [02/30] btrfs: Use a folio in write_dev_supers() [03/30] btrfs: Use the folio iterator in btrfs_end_super_write() [04/30] btrfs: Remove use of the folio error flag [05/30] jfs: Remove use of folio error flag [06/30] bcachefs: Remove calls to folio_set_error [07/30] befs: Convert befs_symlink_read_folio() to use folio_end_read() [08/30] coda: Convert coda_symlink_filler() to use folio_end_read() [09/30] ext2: Remove call to folio_set_error() [10/30] ext4: Remove calls to to set/clear the folio error flag [11/30] fuse: Convert fuse_readpages_end() to use folio_end_read() [12/30] hostfs: Convert hostfs_read_folio() to use a folio [13/30] isofs: Remove calls to set/clear the error flag [14/30] jffs2: Remove calls to set/clear the folio error flag [15/30] nfs: Remove calls to folio_set_error [16/30] nilfs2: Remove calls to folio_set_error() and folio_clear_error() [17/30] ntfs3: Remove calls to set/clear the error flag [18/30] orangefs: Remove calls to set/clear the error flag [19/30] reiserfs: Remove call to folio_set_error() [20/30] romfs: Convert romfs_read_folio() to use a folio [21/30] smb: Remove calls to set folio error flag [22/30] squashfs: Convert squashfs_symlink_read_folio to use folio APIs [23/30] squashfs: Remove calls to set the folio error flag [24/30] ufs: Remove call to set the folio error flag [25/30] vboxsf: Convert vboxsf_read_folio() to use a folio [26/30] mm/memory-failure: Stop setting the folio error flag [27/30] iomap: Remove calls to set and clear folio error flag [28/30] buffer: Remove calls to set and clear the folio error flag [29/30] fs: Remove calls to set and clear the folio error flag [30/30] mm: Remove PG_error

Commit Message

Matthew Wilcox April 20, 2024, 2:50 a.m. UTC

Nobody checks the error flag on ntfs3 folios, so stop setting and
clearing it.

Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: ntfs3@lists.linux.dev
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 fs/ntfs3/frecord.c | 4 ----
 1 file changed, 4 deletions(-)

diff mbox series

Patch

diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
index 7f27382e0ce2..e9836170e2be 100644
--- a/fs/ntfs3/frecord.c
+++ b/fs/ntfs3/frecord.c
@@ -2143,9 +2143,6 @@  int ni_readpage_cmpr(struct ntfs_inode *ni, struct page *page)
 	err = ni_read_frame(ni, frame_vbo, pages, pages_per_frame);
 
 out1:
-	if (err)
-		SetPageError(page);
-
 	for (i = 0; i < pages_per_frame; i++) {
 		pg = pages[i];
 		if (i == idx || !pg)
@@ -2718,7 +2715,6 @@  int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
 	for (i = 0; i < pages_per_frame; i++) {
 		pg = pages[i];
 		kunmap(pg);
-		ClearPageError(pg);
 		SetPageUptodate(pg);
 	}