| Message ID | 20240520090819.76342-1-pchelkin@ispras.ru (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] signalfd: fix error return code | expand |
On 5/20/24 3:08 AM, Fedor Pchelkin wrote: > If anon_inode_getfile() fails, return appropriate error code. This looks > like a single typo: the similar code changes in timerfd and userfaultfd > are okay. Oops yes, that's my bad. Reviewed-by: Jens Axboe <axboe@kernel.dk>
On Mon, 20 May 2024 12:08:18 +0300, Fedor Pchelkin wrote: > If anon_inode_getfile() fails, return appropriate error code. This looks > like a single typo: the similar code changes in timerfd and userfaultfd > are okay. > > Found by Linux Verification Center (linuxtesting.org). > > > [...] Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/2] signalfd: fix error return code https://git.kernel.org/vfs/vfs/c/e8df0c67191f [2/2] signalfd: drop an obsolete comment https://git.kernel.org/vfs/vfs/c/0dda1466f355
diff --git a/fs/signalfd.c b/fs/signalfd.c index 4a5614442dbf..65fe5eed0be4 100644 --- a/fs/signalfd.c +++ b/fs/signalfd.c @@ -282,7 +282,7 @@ static int do_signalfd4(int ufd, sigset_t *mask, int flags) if (IS_ERR(file)) { put_unused_fd(ufd); kfree(ctx); - return ufd; + return PTR_ERR(file); } file->f_mode |= FMODE_NOWAIT;
If anon_inode_getfile() fails, return appropriate error code. This looks like a single typo: the similar code changes in timerfd and userfaultfd are okay. Found by Linux Verification Center (linuxtesting.org). Fixes: fbe38120eb1d ("signalfd: convert to ->read_iter()") Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru> --- fs/signalfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)