| Message ID | 20240520090819.76342-2-pchelkin@ispras.ru (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] signalfd: fix error return code | expand |
On 5/20/24 3:08 AM, Fedor Pchelkin wrote: > Commit fbe38120eb1d ("signalfd: convert to ->read_iter()") removed the > call to anon_inode_getfd() by splitting fd setup into two parts. Drop the > comment referencing the internal details of that function. Reviewed-by: Jens Axboe <axboe@kernel.dk>
diff --git a/fs/signalfd.c b/fs/signalfd.c index 65fe5eed0be4..ec7b2da2477a 100644 --- a/fs/signalfd.c +++ b/fs/signalfd.c @@ -286,10 +286,6 @@ static int do_signalfd4(int ufd, sigset_t *mask, int flags) } file->f_mode |= FMODE_NOWAIT; - /* - * When we call this, the initialization must be complete, since - * anon_inode_getfd() will install the fd. - */ fd_install(ufd, file); } else { struct fd f = fdget(ufd);
Commit fbe38120eb1d ("signalfd: convert to ->read_iter()") removed the call to anon_inode_getfd() by splitting fd setup into two parts. Drop the comment referencing the internal details of that function. Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru> --- fs/signalfd.c | 4 ---- 1 file changed, 4 deletions(-)