diff mbox series

[1/2] udf: Drop pointless IS_IMMUTABLE and IS_APPEND check

Message ID 20240520135056.788-1-jack@suse.cz (mailing list archive)
State New
Headers show
Series udf: Correct lock ordering in udf_setsize() | expand

Commit Message

Jan Kara May 20, 2024, 1:50 p.m. UTC 
udf_setsize() checks for IS_IMMUTABLE and IS_APPEND flags. This is
however pointless as UDF does not have capability to store these flags
and never allows to set them. Furthermore this is the only place in UDF
code that was actually checking these flags. Remove the pointless check.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/udf/inode.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/fs/udf/inode.c b/fs/udf/inode.c
index 2f831a3a91af..04b0e62cf73f 100644
--- a/fs/udf/inode.c
+++ b/fs/udf/inode.c
@@ -1248,8 +1248,6 @@  int udf_setsize(struct inode *inode, loff_t newsize)
 	if (!(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
 	      S_ISLNK(inode->i_mode)))
 		return -EINVAL;
-	if (IS_APPEND(inode) || IS_IMMUTABLE(inode))
-		return -EPERM;
 
 	filemap_invalidate_lock(inode->i_mapping);
 	iinfo = UDF_I(inode);