| Message ID | 20240523-md-adfs-v1-1-364268e38370@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fs/adfs: add MODULE_DESCRIPTION | expand |
On Thu, 23 May 2024 06:58:01 -0700, Jeff Johnson wrote: > Fix the 'make W=1' issue: > WARNING: modpost: missing MODULE_DESCRIPTION() in fs/adfs/adfs.o > > Sure, why not. --- Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] fs/adfs: add MODULE_DESCRIPTION https://git.kernel.org/vfs/vfs/c/5b50aef089d0
On Fri, May 24, 2024 at 03:13:04PM +0200, Christian Brauner wrote: > On Thu, 23 May 2024 06:58:01 -0700, Jeff Johnson wrote: > > Fix the 'make W=1' issue: > > WARNING: modpost: missing MODULE_DESCRIPTION() in fs/adfs/adfs.o > > > > > > Sure, why not. Might make sense to move those into a separate branch, IMO (and feel free to slap ACKed-by: Al Viro <viro@zeniv.linux.org.uk> on those - AFAICS all of them look reasonable).
On Mon, May 27, 2024 at 05:40:22PM +0100, Al Viro wrote: > On Fri, May 24, 2024 at 03:13:04PM +0200, Christian Brauner wrote: > > On Thu, 23 May 2024 06:58:01 -0700, Jeff Johnson wrote: > > > Fix the 'make W=1' issue: > > > WARNING: modpost: missing MODULE_DESCRIPTION() in fs/adfs/adfs.o > > > > > > > > > > Sure, why not. > > Might make sense to move those into a separate branch, IMO (and feel > free to slap ACKed-by: Al Viro <viro@zeniv.linux.org.uk> on those - > AFAICS all of them look reasonable). Thanks! Added Acks to all of them and about to push it to #vfs.module.description.
On 5/28/24 03:00, Christian Brauner wrote: > On Mon, May 27, 2024 at 05:40:22PM +0100, Al Viro wrote: >> On Fri, May 24, 2024 at 03:13:04PM +0200, Christian Brauner wrote: >>> On Thu, 23 May 2024 06:58:01 -0700, Jeff Johnson wrote: >>>> Fix the 'make W=1' issue: >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/adfs/adfs.o >>>> >>>> >>> >>> Sure, why not. >> >> Might make sense to move those into a separate branch, IMO (and feel >> free to slap ACKed-by: Al Viro <viro@zeniv.linux.org.uk> on those - >> AFAICS all of them look reasonable). > > Thanks! Added Acks to all of them and about to push it to > #vfs.module.description. Following up since I don't see this in linux-next and hope to have all of these warnings fixed tree-wide in 6.11. /jeff
On Thu, 23 May 2024 06:58:01 -0700, Jeff Johnson wrote: > Fix the 'make W=1' issue: > WARNING: modpost: missing MODULE_DESCRIPTION() in fs/adfs/adfs.o > > Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/1] fs/adfs: add MODULE_DESCRIPTION https://git.kernel.org/vfs/vfs/c/330367c0700d
diff --git a/fs/adfs/super.c b/fs/adfs/super.c index 9354b14bbfe3..f0b999a4961b 100644 --- a/fs/adfs/super.c +++ b/fs/adfs/super.c @@ -491,4 +491,5 @@ static void __exit exit_adfs_fs(void) module_init(init_adfs_fs) module_exit(exit_adfs_fs) +MODULE_DESCRIPTION("Acorn Disc Filing System"); MODULE_LICENSE("GPL");
Fix the 'make W=1' issue: WARNING: modpost: missing MODULE_DESCRIPTION() in fs/adfs/adfs.o Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- fs/adfs has no MAINTAINERS entry so falling back to the entry for FILESYSTEMS (VFS and infrastructure) --- fs/adfs/super.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: 5c4069234f68372e80e4edfcce260e81fd9da007 change-id: 20240522-md-adfs-48870fc4ba91