diff mbox series

statx: Update offset commentary for struct statx

Message ID 20240529081725.3769290-1-john.g.garry@oracle.com (mailing list archive)
State New
Headers show
Series statx: Update offset commentary for struct statx | expand

Commit Message

John Garry May 29, 2024, 8:17 a.m. UTC
In commit 2a82bb02941f ("statx: stx_subvol"), a new member was added to
struct statx, but the offset comment was not correct. Update it.

Signed-off-by: John Garry <john.g.garry@oracle.com>

Comments

Christian Brauner May 29, 2024, 8:42 a.m. UTC | #1
On Wed, May 29, 2024 at 08:17:25AM +0000, John Garry wrote:
> In commit 2a82bb02941f ("statx: stx_subvol"), a new member was added to
> struct statx, but the offset comment was not correct. Update it.
> 
> Signed-off-by: John Garry <john.g.garry@oracle.com>
> 
> diff --git a/include/uapi/linux/stat.h b/include/uapi/linux/stat.h
> index 67626d535316..95770941ee2c 100644
> --- a/include/uapi/linux/stat.h
> +++ b/include/uapi/linux/stat.h
> @@ -126,8 +126,8 @@ struct statx {
>  	__u64	stx_mnt_id;
>  	__u32	stx_dio_mem_align;	/* Memory buffer alignment for direct I/O */
>  	__u32	stx_dio_offset_align;	/* File offset alignment for direct I/O */
> -	__u64	stx_subvol;	/* Subvolume identifier */
>  	/* 0xa0 */
> +	__u64	stx_subvol;	/* Subvolume identifier */
>  	__u64	__spare3[11];	/* Spare space for future expansion */
>  	/* 0x100 */
>  };
> -- 
> 2.31.1
> 

Thanks, applied.
But note that your patch format seems to have tripped b4. I had to apply
it manually.
Konstantin Ryabitsev May 29, 2024, 8:02 p.m. UTC | #2
On Wed, May 29, 2024 at 10:42:48AM GMT, Christian Brauner wrote:
> But note that your patch format seems to have tripped b4. I had to apply
> it manually.

Looks like it was some mail relay that QP-encoded DKIM headers.
I've committed a fix for it.

Cheers,
-K
diff mbox series

Patch

diff --git a/include/uapi/linux/stat.h b/include/uapi/linux/stat.h
index 67626d535316..95770941ee2c 100644
--- a/include/uapi/linux/stat.h
+++ b/include/uapi/linux/stat.h
@@ -126,8 +126,8 @@  struct statx {
 	__u64	stx_mnt_id;
 	__u32	stx_dio_mem_align;	/* Memory buffer alignment for direct I/O */
 	__u32	stx_dio_offset_align;	/* File offset alignment for direct I/O */
-	__u64	stx_subvol;	/* Subvolume identifier */
 	/* 0xa0 */
+	__u64	stx_subvol;	/* Subvolume identifier */
 	__u64	__spare3[11];	/* Spare space for future expansion */
 	/* 0x100 */
 };