| Message ID | 20240603014834.45294-1-youling.tang@linux.dev (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fs/direct-io: Remove linux/prefetch.h include | expand |
On Mon 03-06-24 09:48:34, Youling Tang wrote: > From: Youling Tang <tangyouling@kylinos.cn> > > After commit c22198e78d52 ("direct-io: remove random prefetches"), Nothing > in this file needs anything from `linux/prefetch.h`. > > Signed-off-by: Youling Tang <tangyouling@kylinos.cn> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/direct-io.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/direct-io.c b/fs/direct-io.c > index b0aafe640fa4..bbd05f1a2145 100644 > --- a/fs/direct-io.c > +++ b/fs/direct-io.c > @@ -37,7 +37,6 @@ > #include <linux/rwsem.h> > #include <linux/uio.h> > #include <linux/atomic.h> > -#include <linux/prefetch.h> > > #include "internal.h" > > @@ -1121,11 +1120,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode, > struct blk_plug plug; > unsigned long align = offset | iov_iter_alignment(iter); > > - /* > - * Avoid references to bdev if not absolutely needed to give > - * the early prefetch in the caller enough time. > - */ > - > /* watch out for a 0 len io from a tricksy fs */ > if (iov_iter_rw(iter) == READ && !count) > return 0; > -- > 2.34.1 >
Hi, On 03/06/2024 19:18, Jan Kara wrote: > On Mon 03-06-24 09:48:34, Youling Tang wrote: >> From: Youling Tang <tangyouling@kylinos.cn> >> >> After commit c22198e78d52 ("direct-io: remove random prefetches"), Nothing >> in this file needs anything from `linux/prefetch.h`. >> >> Signed-off-by: Youling Tang <tangyouling@kylinos.cn> Sorry to bother you, but do we still need this patch? Thanks, Youling. > Looks good. Feel free to add: > > Reviewed-by: Jan Kara <jack@suse.cz> > > Honza > >> --- >> fs/direct-io.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/fs/direct-io.c b/fs/direct-io.c >> index b0aafe640fa4..bbd05f1a2145 100644 >> --- a/fs/direct-io.c >> +++ b/fs/direct-io.c >> @@ -37,7 +37,6 @@ >> #include <linux/rwsem.h> >> #include <linux/uio.h> >> #include <linux/atomic.h> >> -#include <linux/prefetch.h> >> >> #include "internal.h" >> >> @@ -1121,11 +1120,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode, >> struct blk_plug plug; >> unsigned long align = offset | iov_iter_alignment(iter); >> >> - /* >> - * Avoid references to bdev if not absolutely needed to give >> - * the early prefetch in the caller enough time. >> - */ >> - >> /* watch out for a 0 len io from a tricksy fs */ >> if (iov_iter_rw(iter) == READ && !count) >> return 0; >> -- >> 2.34.1 >>
On Wed, Jul 24, 2024 at 03:33:38PM GMT, Youling Tang wrote: > Hi, > > On 03/06/2024 19:18, Jan Kara wrote: > > On Mon 03-06-24 09:48:34, Youling Tang wrote: > > > From: Youling Tang <tangyouling@kylinos.cn> > > > > > > After commit c22198e78d52 ("direct-io: remove random prefetches"), Nothing > > > in this file needs anything from `linux/prefetch.h`. > > > > > > Signed-off-by: Youling Tang <tangyouling@kylinos.cn> > Sorry to bother you, but do we still need this patch? It's in the vfs.misc pile for next merge window.
diff --git a/fs/direct-io.c b/fs/direct-io.c index b0aafe640fa4..bbd05f1a2145 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -37,7 +37,6 @@ #include <linux/rwsem.h> #include <linux/uio.h> #include <linux/atomic.h> -#include <linux/prefetch.h> #include "internal.h" @@ -1121,11 +1120,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode, struct blk_plug plug; unsigned long align = offset | iov_iter_alignment(iter); - /* - * Avoid references to bdev if not absolutely needed to give - * the early prefetch in the caller enough time. - */ - /* watch out for a 0 len io from a tricksy fs */ if (iov_iter_rw(iter) == READ && !count) return 0;