diff mbox series

[v3,09/12] ext4: drop unused ext4_es_store_status()

Message ID 20240813123452.2824659-10-yi.zhang@huaweicloud.com (mailing list archive)
State New
Headers show
Series ext4: simplify the counting and management of delalloc reserved blocks | expand

Commit Message

Zhang Yi Aug. 13, 2024, 12:34 p.m. UTC 
From: Zhang Yi <yi.zhang@huawei.com>

The helper ext4_es_store_status() is unused now, just drop it.

Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
---
 fs/ext4/extents_status.h | 7 -------
 1 file changed, 7 deletions(-)

Comments

Jan Kara Sept. 4, 2024, 10:25 a.m. UTC | #1 
On Tue 13-08-24 20:34:49, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@huawei.com>
> 
> The helper ext4_es_store_status() is unused now, just drop it.
> 
> Signed-off-by: Zhang Yi <yi.zhang@huawei.com>

Yes. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

									Honza

> ---
>  fs/ext4/extents_status.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/fs/ext4/extents_status.h b/fs/ext4/extents_status.h
> index 47b3b55a852c..3ca40f018994 100644
> --- a/fs/ext4/extents_status.h
> +++ b/fs/ext4/extents_status.h
> @@ -224,13 +224,6 @@ static inline void ext4_es_store_pblock(struct extent_status *es,
>  	es->es_pblk = block;
>  }
>  
> -static inline void ext4_es_store_status(struct extent_status *es,
> -					unsigned int status)
> -{
> -	es->es_pblk = (((ext4_fsblk_t)status << ES_SHIFT) & ES_MASK) |
> -		      (es->es_pblk & ~ES_MASK);
> -}
> -
>  static inline void ext4_es_store_pblock_status(struct extent_status *es,
>  					       ext4_fsblk_t pb,
>  					       unsigned int status)
> -- 
> 2.39.2
>
diff mbox series

Patch

diff --git a/fs/ext4/extents_status.h b/fs/ext4/extents_status.h
index 47b3b55a852c..3ca40f018994 100644
--- a/fs/ext4/extents_status.h
+++ b/fs/ext4/extents_status.h
@@ -224,13 +224,6 @@  static inline void ext4_es_store_pblock(struct extent_status *es,
 	es->es_pblk = block;
 }
 
-static inline void ext4_es_store_status(struct extent_status *es,
-					unsigned int status)
-{
-	es->es_pblk = (((ext4_fsblk_t)status << ES_SHIFT) & ES_MASK) |
-		      (es->es_pblk & ~ES_MASK);
-}
-
 static inline void ext4_es_store_pblock_status(struct extent_status *es,
 					       ext4_fsblk_t pb,
 					       unsigned int status)