From patchwork Sun Sep 1 13:37:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Schubert X-Patchwork-Id: 13786424 Received: from outbound-ip191a.ess.barracuda.com (outbound-ip191a.ess.barracuda.com [209.222.82.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4470B143C6C; Sun, 1 Sep 2024 13:37:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=209.222.82.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725197840; cv=fail; b=sMvjtN5+145gOUITIpODfcjORkhgYvaxqMBf/tPTV9V9b2trLaDXmB1dl/JYVEMDioHwpihRHV3P4FRTT7hEUt6BXnuIC3wGT/Ps+dMyj+T9d0yOXapVgjHt19DEZfIzFwxthBSnnKtLNyaXZwFQzad02Z1fARkqEd6DKawbYJs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725197840; c=relaxed/simple; bh=XKaocKew3lcYQPHAH8W6P7pyorB0iIVLO/jnXgQCYQo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MutYQlycVidzOzbxek2t7GDmMub/yb88K7+KaNOZGlO33m8tSjJk67oNva8rmKuruMPIeyY4gcj5lQoqKOPe9a8b4XWvIrbHDkg/28YLfvU4OYcQSDo7EdM3ZkWmMqZLwAldBJ5SRMyGD0CYi8r9CDh3TnsaZHKgA18DhVR4rIQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ddn.com; spf=pass smtp.mailfrom=ddn.com; dkim=pass (1024-bit key) header.d=ddn.com header.i=@ddn.com header.b=1PKpnwST; arc=fail smtp.client-ip=209.222.82.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ddn.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ddn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ddn.com header.i=@ddn.com header.b="1PKpnwST" Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2173.outbound.protection.outlook.com [104.47.58.173]) by mx-outbound-ea15-210.us-east-2a.ess.aws.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 01 Sep 2024 13:37:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kCX7ByqWB03kmPevpLTmKdt4rlqVTBwDxd2uG1/j1msje/o0zHDCb55stZ6e1xkjonE32SdCtqRV8xfAQSPRUc+VD4AmgaPtUNBDc7j/A9CS0uKWFhpeRJ5iAEHLOaI/lhkNS2uKd5+BivyYhaM+gjcrQ6M4lTfSLWk5/3POu1v3eQKTmN9OwvhoqdcScACgU2KTRH+pZs/uLtngLmWnbO0avp+rquUFyNoB2CizMeX/DilYETEGLImIaTnbEUBvRnIpZvBJMWHUuz0CUe3YGcF6mPiCSYQpn6p/9VPr7TWWuZON6/07A8RgGpZtaRtLQ3Ae4yNeJ4iorzUw/+HDEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QmPiQBUvsMtW8+yplJP+3lFYxN3/0veiUZKKkafplYA=; b=WB5ic5qsSDeQNBQuRFUxI5ZZCeepoid4KfJNKFuBi9nQVGx/NcSJuLAp8EDT0BWgcD502R5pEEjx8fRGSavUSsBa7xD1BDdzWNzQb0yjQYHXQvptQvtOz2+OAV0wcgo9QG5d2FpAkYsRyNaxyghrWwUszooOMKZa3z/ExUZduEhJcVfPBM3tyGnC1bh1YnGpFmGBifZo8fjT8n//+mSSOavPZHQC2ekvNWNGLoQWElrrFGmqenyTj6+u4DRrAXJaO3mi7AMgtRIhB7Itr45vfnVk9ePmxfP6ogd4pr3mRshkW+W88aE4xK3XFDamy1g3/CcDsCtsRcVjns+VILEeiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 50.222.100.11) smtp.rcpttodomain=ddn.com smtp.mailfrom=ddn.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ddn.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ddn.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QmPiQBUvsMtW8+yplJP+3lFYxN3/0veiUZKKkafplYA=; b=1PKpnwSTKvWSo2HDflVE4NkD2y/pXp/PbWIOZhJENhCs4rpXlct6pbp3BQDhUOmxZ5Gb1VQxuOWNQIBcMWcXILF5UkeLGjE90NRGda6YXLe3ZIhrZxpilD3+X9RzuOzNzG4/AyAp6KeQDaBeiyhOZ1hpWXxb6B6Fx4lytPnan4E= Received: from PH0PR07CA0014.namprd07.prod.outlook.com (2603:10b6:510:5::19) by PH7PR19MB7310.namprd19.prod.outlook.com (2603:10b6:510:272::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.23; Sun, 1 Sep 2024 13:37:08 +0000 Received: from CO1PEPF000075F3.namprd03.prod.outlook.com (2603:10b6:510:5:cafe::13) by PH0PR07CA0014.outlook.office365.com (2603:10b6:510:5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.21 via Frontend Transport; Sun, 1 Sep 2024 13:37:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 50.222.100.11) smtp.mailfrom=ddn.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ddn.com; Received-SPF: Pass (protection.outlook.com: domain of ddn.com designates 50.222.100.11 as permitted sender) receiver=protection.outlook.com; client-ip=50.222.100.11; helo=uww-mrp-01.datadirectnet.com; pr=C Received: from uww-mrp-01.datadirectnet.com (50.222.100.11) by CO1PEPF000075F3.mail.protection.outlook.com (10.167.249.42) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Sun, 1 Sep 2024 13:37:08 +0000 Received: from localhost (unknown [10.68.0.8]) by uww-mrp-01.datadirectnet.com (Postfix) with ESMTP id 68A5BD0; Sun, 1 Sep 2024 13:37:06 +0000 (UTC) From: Bernd Schubert Date: Sun, 01 Sep 2024 15:37:03 +0200 Subject: [PATCH RFC v3 09/17] fuse: Make fuse_copy non static Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240901-b4-fuse-uring-rfcv3-without-mmap-v3-9-9207f7391444@ddn.com> References: <20240901-b4-fuse-uring-rfcv3-without-mmap-v3-0-9207f7391444@ddn.com> In-Reply-To: <20240901-b4-fuse-uring-rfcv3-without-mmap-v3-0-9207f7391444@ddn.com> To: Miklos Szeredi , Jens Axboe , Pavel Begunkov , bernd@fastmail.fm Cc: linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Joanne Koong , Josef Bacik , Amir Goldstein , Bernd Schubert X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1725197817; l=3552; i=bschubert@ddn.com; s=20240529; h=from:subject:message-id; bh=XKaocKew3lcYQPHAH8W6P7pyorB0iIVLO/jnXgQCYQo=; b=rJl1Jo9v7DfM8AkAuAI3AOmnpMN13ARZGgJIYcM9k0d50f8IQJ8tOZnIGS2TAahVN60wNtus1 Sv1qZ0i8/CJAdwoPMHI+wQge2iJFG3TJWDT+d5uHKMUKvJB6x+gnJgb X-Developer-Key: i=bschubert@ddn.com; a=ed25519; pk=EZVU4bq64+flgoWFCVQoj0URAs3Urjno+1fIq9ZJx8Y= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000075F3:EE_|PH7PR19MB7310:EE_ X-MS-Office365-Filtering-Correlation-Id: ec3696a3-b853-4aa8-3478-08dcca8b2ce3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?q?rzMe+2d6NeYNBxzBZIIsGGSeXNlMQk0?= =?utf-8?q?Zkw3ZSDyK84XfeuHgV+83IVY3AK0OPr/Lo4Jy5XmHt4xte7EhZ2qKh1e0XX3Xlbl4?= =?utf-8?q?RDhNFHjVKZUEH+gL5UCBPN8Z+EJ+xMHVpjXObOtTU0h8bwmelWFlROefoqnW99acp?= =?utf-8?q?CLbvnUJzvZi9M05zkldSsKfsL/zwXntIDmWDVqtH1bKuQQ7NTr3qidgpmlm021a4e?= =?utf-8?q?Ohd2Xp/1998n6z/2Nb5HBiGmNqlt6k4zsmUFByHGCsvsumuQ76TkKqdwjO1LjR1XA?= =?utf-8?q?6WwJtthd9QVYcHmzWqEc0VTeODoqGySLDW74/L0HO1y6a9baOfUc5E4ewzADIO51N?= =?utf-8?q?Elmkxfrum2hCo/LwgZVAZQ49qr+Chg4U4JqlTfLCAFtx5fnpHm9u6uztwZHh0Dcf4?= =?utf-8?q?oLYfTSjCg6wrhJbuY1vUxylXVd+mkr2pT2hRY/euyWsafGbOyVTw+T/2Soxig9Vfz?= =?utf-8?q?uYc34hER/MyJSKY3gJitfCtMo5nJBQWor1jJ7kKia8ZCfAxRF9YvWnLOHl0oTZ4Cu?= =?utf-8?q?62CZrC3uV4sN0z6iiPcBpvtz5FNS06tJOZhP5sjL4kfX8fAB1LpoETCl4Btu7FIXR?= =?utf-8?q?oc98nGpqURiPMSqx7n4UKNSzjEzUj4G/jRuynDjo6F9ew8jmHWuNIUKymxGx+MQ8h?= =?utf-8?q?cmdAyXf8QBihMQMWQeYbJ7EPaeubBRpflqD2fTUnb8jeI6bcVahdti+a5w/m4rNbV?= =?utf-8?q?Om5SqqWut/PfNTv0JtCYYxbIl+gmJyxyw9kc5jfskD2oXaJI9aA3scvcqk22v57gn?= =?utf-8?q?8qofM/RS5ZGycB17hKLPTa61WWCpFbRZjK8cjnMnA4sYU5i/du6PPT86jKrvBxlT+?= =?utf-8?q?4KOj/3/ot61enz+xaZtycE3trn7RpyE84M9Hn5c9SiXA3RMSEIOWs6Yr25MoiU6MG?= =?utf-8?q?85rQJBk8Fk1YbJvpo3x/F3IKEiRj8aQsPPbL3H4EZvShz79jE9mFy+/47o+5ftH1A?= =?utf-8?q?tehPltOL1rtRcP7OGAByHzKOKwZG4u38gl6TR4IxaYbah7u5NiMUCs+s3fMLAmkzF?= =?utf-8?q?lRTCFxu2Rs4MamxN4cfsEBvjgQFKqmSyZ+LeobBtnKwboiVJXroqhlNQhcUt4HFma?= =?utf-8?q?66DClYVhazfCSf7XgGzAd9gauGFx0OAaJQ0FsaLdcYfee8ZLGksWS8BRIli9amGPM?= =?utf-8?q?3KVDq87fa0t5faBPkgEiOvTV1jIkeIBhxZOeUq8hjUUTxmL0HtIKp5pzxNQ1mIPxN?= =?utf-8?q?ylzArHpQx0u6DefdBcqlHhf3ziRSVqOlG/D5vWSDp/MomVgXOGMwNyqHjWdVd6VxU?= =?utf-8?q?1XQPsBAA3g8Q/kyGZ98ILsMq5XKy5bnX5NlkSr3dAG5GhlMPYoC1OIDpwThGrzHmg?= =?utf-8?q?NipZsmt0/SB76kJ1Cnke19CLapeFGn9iL9+eAmtMwBgXMpQjZ6iq3tmjllcSMa4WF?= =?utf-8?q?3sK1jcuco8T?= X-Forefront-Antispam-Report: CIP:50.222.100.11;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:uww-mrp-01.datadirectnet.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: euwJ9ved8mXt9VcAImGHr9Uq+PtIUndxMvtC3k4xdV6sBBTAFsNO3XP+kMXefAGdPcpOJZA2J+PuHdkdZOGlFc22ALRLnqm2INtSx5+xZT6DZ0zMJ8AoTOUpTIHPFxvxvroYJRJlRFMtesm5D0KoUscUBYj+ivGfsR8Af36s+EJqrxYcIoY4dslX15ZQ2691pni3NonU7RRHBB/4AmiXT8ee0cLWGBKy2rVuWDMwfIgLZVtQTwMROuVUlREGWbA1YtFijL12Ye4/nGbQc6M49I5VK/9Orfj4IjfwI29w/FW0K9ANT6CBeQAQJlcpmWOlulCSKELTxYEznVAvzm/lsaoOc74EbBtOtisrZQ48c/bt4ckrnhnynkbiZ1OrL8IjsHAdqRxTPg9+6g2S8C5CvHk6MOBaqjbY+7fb3CfCNSt8CSamIYfU+TP52ZqZhCf5Guam/i7btQqbgiBgRnW/IuySymHKI/Nh0NoaY8pH1odZZYGe6NXeEpWnln0RFtLojuOlVPrDhjgRGLn3l9ASKfzjyh7j8nHssNZW9MQ8kJQ+H+aiWqVq+TF/xdHt7opPduzYNr+Qw+dwM5TQK9m6xVOaq4O14akxrwWaXgMFxYfYouog7fsI9xmVXdzWJZjy9MLSAdoX1pP8ZIFhJY8e9A== X-OriginatorOrg: ddn.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2024 13:37:08.0714 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ec3696a3-b853-4aa8-3478-08dcca8b2ce3 X-MS-Exchange-CrossTenant-Id: 753b6e26-6fd3-43e6-8248-3f1735d59bb4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=753b6e26-6fd3-43e6-8248-3f1735d59bb4;Ip=[50.222.100.11];Helo=[uww-mrp-01.datadirectnet.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000075F3.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR19MB7310 X-BESS-ID: 1725197831-104050-6777-5849-1 X-BESS-VER: 2019.3_20240829.2013 X-BESS-Apparent-Source-IP: 104.47.58.173 X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVsYmxqZAVgZQ0NLQNMkoLSUl2T TV2MgkMS0pyTTJ1DTN3MLEItE0OclUqTYWAJClDLtBAAAA X-BESS-Outbound-Spam-Score: 0.50 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.258743 [from cloudscan23-79.us-east-2b.ess.aws.cudaops.com] Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.50 BSF_RULE_7582B META: Custom Rule 7582B 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.50 using account:ESS124931 scores of KILL_LEVEL=7.0 tests=BSF_RULE_7582B, BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 Move 'struct fuse_copy_state' and fuse_copy_* functions to fuse_dev_i.h to make it available for fuse-uring. 'copy_out_args()' is renamed to 'fuse_copy_out_args'. Signed-off-by: Bernd Schubert --- fs/fuse/dev.c | 30 ++++++++---------------------- fs/fuse/fuse_dev_i.h | 25 +++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 22 deletions(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 998027825481..9e012c902df2 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -637,22 +637,8 @@ static int unlock_request(struct fuse_req *req) return err; } -struct fuse_copy_state { - int write; - struct fuse_req *req; - struct iov_iter *iter; - struct pipe_buffer *pipebufs; - struct pipe_buffer *currbuf; - struct pipe_inode_info *pipe; - unsigned long nr_segs; - struct page *pg; - unsigned len; - unsigned offset; - unsigned move_pages:1; -}; - -static void fuse_copy_init(struct fuse_copy_state *cs, int write, - struct iov_iter *iter) +void fuse_copy_init(struct fuse_copy_state *cs, int write, + struct iov_iter *iter) { memset(cs, 0, sizeof(*cs)); cs->write = write; @@ -1006,9 +992,9 @@ static int fuse_copy_one(struct fuse_copy_state *cs, void *val, unsigned size) } /* Copy request arguments to/from userspace buffer */ -static int fuse_copy_args(struct fuse_copy_state *cs, unsigned numargs, - unsigned argpages, struct fuse_arg *args, - int zeroing) +int fuse_copy_args(struct fuse_copy_state *cs, unsigned numargs, + unsigned argpages, struct fuse_arg *args, + int zeroing) { int err = 0; unsigned i; @@ -1874,8 +1860,8 @@ static struct fuse_req *request_find(struct fuse_pqueue *fpq, u64 unique) return NULL; } -static int copy_out_args(struct fuse_copy_state *cs, struct fuse_args *args, - unsigned nbytes) +int fuse_copy_out_args(struct fuse_copy_state *cs, struct fuse_args *args, + unsigned nbytes) { unsigned reqsize = sizeof(struct fuse_out_header); @@ -1977,7 +1963,7 @@ static ssize_t fuse_dev_do_write(struct fuse_dev *fud, if (oh.error) err = nbytes != sizeof(oh) ? -EINVAL : 0; else - err = copy_out_args(cs, req->args, nbytes); + err = fuse_copy_out_args(cs, req->args, nbytes); fuse_copy_finish(cs); spin_lock(&fpq->lock); diff --git a/fs/fuse/fuse_dev_i.h b/fs/fuse/fuse_dev_i.h index e6289bafb788..0fc7a0ff7b1c 100644 --- a/fs/fuse/fuse_dev_i.h +++ b/fs/fuse/fuse_dev_i.h @@ -13,6 +13,23 @@ #define FUSE_INT_REQ_BIT (1ULL << 0) #define FUSE_REQ_ID_STEP (1ULL << 1) +struct fuse_arg; +struct fuse_args; + +struct fuse_copy_state { + int write; + struct fuse_req *req; + struct iov_iter *iter; + struct pipe_buffer *pipebufs; + struct pipe_buffer *currbuf; + struct pipe_inode_info *pipe; + unsigned long nr_segs; + struct page *pg; + unsigned int len; + unsigned int offset; + unsigned int move_pages:1; +}; + static inline struct fuse_dev *fuse_get_dev(struct file *file) { /* @@ -24,6 +41,14 @@ static inline struct fuse_dev *fuse_get_dev(struct file *file) void fuse_dev_end_requests(struct list_head *head); +void fuse_copy_init(struct fuse_copy_state *cs, int write, + struct iov_iter *iter); +int fuse_copy_args(struct fuse_copy_state *cs, unsigned int numargs, + unsigned int argpages, struct fuse_arg *args, + int zeroing); +int fuse_copy_out_args(struct fuse_copy_state *cs, struct fuse_args *args, + unsigned int nbytes); + #endif