| Message ID | 20240904-pipe-correct_imprecise_wording-v1-1-2b07843472c2@efficios.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fs/pipe: Correct imprecise wording in comment | expand |
On Wed, 04 Sep 2024 10:13:29 -0400, Kienan Stewart wrote: > The comment inaccurately describes what pipefs is - that is, a file > system. > > Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] fs/pipe: Correct imprecise wording in comment https://git.kernel.org/vfs/vfs/c/a5796d69bf18
diff --git a/fs/pipe.c b/fs/pipe.c index 7dff2aa50a6d..9a6dfe39f012 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -1427,7 +1427,7 @@ static const struct super_operations pipefs_ops = { /* * pipefs should _never_ be mounted by userland - too much of security hassle, - * no real gain from having the whole whorehouse mounted. So we don't need + * no real gain from having the whole file system mounted. So we don't need * any operations on the root directory. However, we need a non-trivial * d_name - pipe: will go nicely and kill the special-casing in procfs. */
The comment inaccurately describes what pipefs is - that is, a file system. Signed-off-by: Kienan Stewart <kstewart@efficios.com> --- Hi, while reading through `pipe.c`, I noticed that the comment explaining why pipefs should not be mounted in user space inaccurately describes what pipefs is - that is, a file system. While I understand the original language used in context, I believe this change increases the legibility of the comment. thanks, kienan --- fs/pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: d5d547aa7b51467b15d9caa86b116f8c2507c72a change-id: 20240829-pipe-correct_imprecise_wording-d20e370edbc0 Best regards,