| Message ID | 20240913011004.128859-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] fs/inode: Modify mismatched function name | expand |
On Fri 13-09-24 09:10:04, Jiapeng Chong wrote: > No functional modification involved. > > fs/inode.c:242: warning: expecting prototype for inode_init_always(). Prototype was for inode_init_always_gfp() instead. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10845 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> I think this is a fallout from Michal's patch [1] which will be respinned anyway AFAIU. Michal, can you please fixup the kernel doc when sending new version of the patch? Thanks! Honza [1] https://lore.kernel.org/all/20240827061543.1235703-1-mhocko@kernel.org/ > --- > fs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/inode.c b/fs/inode.c > index c391365cdfa7..6763900a7a87 100644 > --- a/fs/inode.c > +++ b/fs/inode.c > @@ -229,7 +229,7 @@ static int no_open(struct inode *inode, struct file *file) > } > > /** > - * inode_init_always - perform inode structure initialisation > + * inode_init_always_gfp - perform inode structure initialisation > * @sb: superblock inode belongs to > * @inode: inode to initialise > * @gfp: allocation flags > -- > 2.32.0.3.g01195cf9f >
On Fri 13-09-24 12:29:35, Jan Kara wrote: > On Fri 13-09-24 09:10:04, Jiapeng Chong wrote: > > No functional modification involved. > > > > fs/inode.c:242: warning: expecting prototype for inode_init_always(). Prototype was for inode_init_always_gfp() instead. > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10845 > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > I think this is a fallout from Michal's patch [1] which will be respinned > anyway AFAIU. Michal, can you please fixup the kernel doc when sending new > version of the patch? Thanks! Yes, I will. Thanks for heads up.
diff --git a/fs/inode.c b/fs/inode.c index c391365cdfa7..6763900a7a87 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -229,7 +229,7 @@ static int no_open(struct inode *inode, struct file *file) } /** - * inode_init_always - perform inode structure initialisation + * inode_init_always_gfp - perform inode structure initialisation * @sb: superblock inode belongs to * @inode: inode to initialise * @gfp: allocation flags
No functional modification involved. fs/inode.c:242: warning: expecting prototype for inode_init_always(). Prototype was for inode_init_always_gfp() instead. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10845 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- fs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)