| Message ID | 20240930112121.95324-10-Julia.Lawall@inria.fr (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Reorganize kerneldoc parameter names | expand |
On Mon, Sep 30, 2024 at 01:20:55PM +0200, Julia Lawall wrote: > Reorganize kerneldoc parameter names to match the parameter > order in the function header. > > Problems identified using Coccinelle. > > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> > > --- > kernel/sysctl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 79e6cb1d5c48..5c9202cb8f59 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -1305,7 +1305,6 @@ int proc_dointvec_userhz_jiffies(const struct ctl_table *table, int write, > * @write: %TRUE if this is a write to the sysctl file > * @buffer: the user buffer > * @lenp: the size of the user buffer > - * @ppos: file position > * @ppos: the current position in the file > * > * Reads/writes up to table->maxlen/sizeof(unsigned int) integer > This looks good to me. Is it going to go into main line together with the other 35 or should I take this one through sysctl subsystem? Best Signed-off-by: Joel Granados <joel.granados@kernel.com>
On Tue, 22 Oct 2024, Joel Granados wrote: > On Mon, Sep 30, 2024 at 01:20:55PM +0200, Julia Lawall wrote: > > Reorganize kerneldoc parameter names to match the parameter > > order in the function header. > > > > Problems identified using Coccinelle. > > > > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> > > > > --- > > kernel/sysctl.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > > index 79e6cb1d5c48..5c9202cb8f59 100644 > > --- a/kernel/sysctl.c > > +++ b/kernel/sysctl.c > > @@ -1305,7 +1305,6 @@ int proc_dointvec_userhz_jiffies(const struct ctl_table *table, int write, > > * @write: %TRUE if this is a write to the sysctl file > > * @buffer: the user buffer > > * @lenp: the size of the user buffer > > - * @ppos: file position > > * @ppos: the current position in the file > > * > > * Reads/writes up to table->maxlen/sizeof(unsigned int) integer > > > This looks good to me. Is it going to go into main line together with > the other 35 or should I take this one through sysctl subsystem? Please take it, julia > > Best > > Signed-off-by: Joel Granados <joel.granados@kernel.com> > > -- > > Joel Granados >
On Tue, Oct 22, 2024 at 01:13:25PM -0700, Julia Lawall wrote: > > > On Tue, 22 Oct 2024, Joel Granados wrote: > > > On Mon, Sep 30, 2024 at 01:20:55PM +0200, Julia Lawall wrote: > > > Reorganize kerneldoc parameter names to match the parameter > > > order in the function header. > > > > > > Problems identified using Coccinelle. > > > > > > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> > > > > > > --- > > > kernel/sysctl.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > > > index 79e6cb1d5c48..5c9202cb8f59 100644 > > > --- a/kernel/sysctl.c > > > +++ b/kernel/sysctl.c > > > @@ -1305,7 +1305,6 @@ int proc_dointvec_userhz_jiffies(const struct ctl_table *table, int write, > > > * @write: %TRUE if this is a write to the sysctl file > > > * @buffer: the user buffer > > > * @lenp: the size of the user buffer > > > - * @ppos: file position > > > * @ppos: the current position in the file > > > * > > > * Reads/writes up to table->maxlen/sizeof(unsigned int) integer > > > > > This looks good to me. Is it going to go into main line together with > > the other 35 or should I take this one through sysctl subsystem? > > Please take it, Ok. I added to the sysctl-next branch going into the next release. thx. Best
diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 79e6cb1d5c48..5c9202cb8f59 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -1305,7 +1305,6 @@ int proc_dointvec_userhz_jiffies(const struct ctl_table *table, int write, * @write: %TRUE if this is a write to the sysctl file * @buffer: the user buffer * @lenp: the size of the user buffer - * @ppos: file position * @ppos: the current position in the file * * Reads/writes up to table->maxlen/sizeof(unsigned int) integer
Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> --- kernel/sysctl.c | 1 - 1 file changed, 1 deletion(-)