| Message ID | 20250207133502.24209-1-luis@igalia.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fuse: removed unused function fuse_uring_create() from header | expand |
On 2/7/25 14:35, Luis Henriques wrote: > Function fuse_uring_create() is used only from dev_uring.c and does not > need to be exposed in the header file. Furthermore, it has the wrong > signature. > > While there, also remove the 'struct fuse_ring' forward declaration. > > Signed-off-by: Luis Henriques <luis@igalia.com> > --- > fs/fuse/dev_uring_i.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/fuse/dev_uring_i.h b/fs/fuse/dev_uring_i.h > index 2102b3d0c1ae..0d67738850c5 100644 > --- a/fs/fuse/dev_uring_i.h > +++ b/fs/fuse/dev_uring_i.h > @@ -172,12 +172,6 @@ static inline bool fuse_uring_ready(struct fuse_conn *fc) > > #else /* CONFIG_FUSE_IO_URING */ > > -struct fuse_ring; > - > -static inline void fuse_uring_create(struct fuse_conn *fc) > -{ > -} > - > static inline void fuse_uring_destruct(struct fuse_conn *fc) > { > } Ah yes, that is left over from earlier patch sets that were still using ioctls. Reviewed-by: Bernd Schubert <bschubert@ddn.com>
On Fri, 7 Feb 2025 at 14:35, Luis Henriques <luis@igalia.com> wrote: > > Function fuse_uring_create() is used only from dev_uring.c and does not > need to be exposed in the header file. Furthermore, it has the wrong > signature. > > While there, also remove the 'struct fuse_ring' forward declaration. Applied, thanks. Miklos
diff --git a/fs/fuse/dev_uring_i.h b/fs/fuse/dev_uring_i.h index 2102b3d0c1ae..0d67738850c5 100644 --- a/fs/fuse/dev_uring_i.h +++ b/fs/fuse/dev_uring_i.h @@ -172,12 +172,6 @@ static inline bool fuse_uring_ready(struct fuse_conn *fc) #else /* CONFIG_FUSE_IO_URING */ -struct fuse_ring; - -static inline void fuse_uring_create(struct fuse_conn *fc) -{ -} - static inline void fuse_uring_destruct(struct fuse_conn *fc) { }
Function fuse_uring_create() is used only from dev_uring.c and does not need to be exposed in the header file. Furthermore, it has the wrong signature. While there, also remove the 'struct fuse_ring' forward declaration. Signed-off-by: Luis Henriques <luis@igalia.com> --- fs/fuse/dev_uring_i.h | 6 ------ 1 file changed, 6 deletions(-)