| Message ID | 20250318004152.3399104-1-joannelkoong@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] fuse: remove unneeded atomic set in uring creation | expand |
On 3/18/25 01:41, Joanne Koong wrote: > When the ring is allocated, it is kzalloc-ed. ring->queue_refs will > already be initialized to 0 by default. It does not need to be > atomically set to 0. > > Signed-off-by: Joanne Koong <joannelkoong@gmail.com> > --- > fs/fuse/dev_uring.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/fuse/dev_uring.c b/fs/fuse/dev_uring.c > index ab8c26042aa8..f54d150330a9 100644 > --- a/fs/fuse/dev_uring.c > +++ b/fs/fuse/dev_uring.c > @@ -239,7 +239,6 @@ static struct fuse_ring *fuse_uring_create(struct fuse_conn *fc) > ring->nr_queues = nr_queues; > ring->fc = fc; > ring->max_payload_sz = max_payload_size; > - atomic_set(&ring->queue_refs, 0); > > spin_unlock(&fc->lock); > return ring; Thank you, LGTM. I don't remember why I had added that explicit initialization. Reviewed-by: Bernd Schubert <bschubert@ddn.com>
diff --git a/fs/fuse/dev_uring.c b/fs/fuse/dev_uring.c index ab8c26042aa8..f54d150330a9 100644 --- a/fs/fuse/dev_uring.c +++ b/fs/fuse/dev_uring.c @@ -239,7 +239,6 @@ static struct fuse_ring *fuse_uring_create(struct fuse_conn *fc) ring->nr_queues = nr_queues; ring->fc = fc; ring->max_payload_sz = max_payload_size; - atomic_set(&ring->queue_refs, 0); spin_unlock(&fc->lock); return ring;
When the ring is allocated, it is kzalloc-ed. ring->queue_refs will already be initialized to 0 by default. It does not need to be atomically set to 0. Signed-off-by: Joanne Koong <joannelkoong@gmail.com> --- fs/fuse/dev_uring.c | 1 - 1 file changed, 1 deletion(-)