| Message ID | 20250323034725.32329-1-richard120310@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | docs: vfs: Update struct file_system_type | expand |
On Sun, Mar 23, 2025 at 11:47:25AM +0800, I Hsin Cheng wrote: > The structure definition now in the kernel adds macros defining the > value of "fs_flags", and the value "FS_NO_DCACHE" no longer exists, > update it to an existing flag value. What value does it add to duplicate these flag definitions in the documentation? I would not do this. > @@ -140,7 +148,7 @@ members are defined: > "msdos" and so on > > ``fs_flags`` > - various flags (i.e. FS_REQUIRES_DEV, FS_NO_DCACHE, etc.) > + various flags (i.e. FS_REQUIRES_DEV, FS_BINARY_MOUNTDATA, etc.) This should be "eg.", not "i.e."
On Sun, Mar 23, 2025 at 02:24:09PM +0000, Matthew Wilcox wrote: > On Sun, Mar 23, 2025 at 11:47:25AM +0800, I Hsin Cheng wrote: > > The structure definition now in the kernel adds macros defining the > > value of "fs_flags", and the value "FS_NO_DCACHE" no longer exists, > > update it to an existing flag value. > > What value does it add to duplicate these flag definitions in the > documentation? I would not do this. > > > @@ -140,7 +148,7 @@ members are defined: > > "msdos" and so on > > > > ``fs_flags`` > > - various flags (i.e. FS_REQUIRES_DEV, FS_NO_DCACHE, etc.) > > + various flags (i.e. FS_REQUIRES_DEV, FS_BINARY_MOUNTDATA, etc.) > > This should be "eg.", not "i.e." Hi Matthew, Thanks for your kindly reply! > What value does it add to duplicate these flag definitions in the > documentation? I would not do this. I thought the documentation should follow the exact code as in the kernel, if it only serves as a roughly example, I agree with you then. > This should be "eg.", not "i.e." Sure, I'll change it and send v2. Let me know if anything more is needed to be correct, thanks! Best regards, I Hsin Cheng
diff --git a/Documentation/filesystems/vfs.rst b/Documentation/filesystems/vfs.rst index 31eea688609a..4e7fa09ffb6d 100644 --- a/Documentation/filesystems/vfs.rst +++ b/Documentation/filesystems/vfs.rst @@ -115,6 +115,14 @@ members are defined: struct file_system_type { const char *name; int fs_flags; + #define FS_REQUIRES_DEV 1 + #define FS_BINARY_MOUNTDATA 2 + #define FS_HAS_SUBTYPE 4 + #define FS_USERNS_MOUNT 8 /* Can be mounted by userns root */ + #define FS_DISALLOW_NOTIFY_PERM 16 /* Disable fanotify permission events */ + #define FS_ALLOW_IDMAP 32 /* FS has been updated to handle vfs idmappings. */ + #define FS_MGTIME 64 /* FS uses multigrain timestamps */ + #define FS_RENAME_DOES_D_MOVE 32768 /* FS will handle d_move() during rename() internally. */ int (*init_fs_context)(struct fs_context *); const struct fs_parameter_spec *parameters; struct dentry *(*mount) (struct file_system_type *, int, @@ -140,7 +148,7 @@ members are defined: "msdos" and so on ``fs_flags`` - various flags (i.e. FS_REQUIRES_DEV, FS_NO_DCACHE, etc.) + various flags (i.e. FS_REQUIRES_DEV, FS_BINARY_MOUNTDATA, etc.) ``init_fs_context`` Initializes 'struct fs_context' ->ops and ->fs_private fields with
The structure definition now in the kernel adds macros defining the value of "fs_flags", and the value "FS_NO_DCACHE" no longer exists, update it to an existing flag value. Signed-off-by: I Hsin Cheng <richard120310@gmail.com> --- Documentation/filesystems/vfs.rst | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)