| Message ID | 20250407-work-anon_inode-v1-6-53a44c20d44e@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fs: harden anon inodes | expand |
On Mon 07-04-25 11:54:20, Christian Brauner wrote: > Test that anonymous inodes cannot be chown()ed. > > Signed-off-by: Christian Brauner <brauner@kernel.org> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > tools/testing/selftests/filesystems/.gitignore | 1 + > tools/testing/selftests/filesystems/Makefile | 2 +- > .../selftests/filesystems/anon_inode_test.c | 26 ++++++++++++++++++++++ > 3 files changed, 28 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/filesystems/.gitignore b/tools/testing/selftests/filesystems/.gitignore > index 828b66a10c63..7afa58e2bb20 100644 > --- a/tools/testing/selftests/filesystems/.gitignore > +++ b/tools/testing/selftests/filesystems/.gitignore > @@ -2,3 +2,4 @@ > dnotify_test > devpts_pts > file_stressor > +anon_inode_test > diff --git a/tools/testing/selftests/filesystems/Makefile b/tools/testing/selftests/filesystems/Makefile > index 66305fc34c60..b02326193fee 100644 > --- a/tools/testing/selftests/filesystems/Makefile > +++ b/tools/testing/selftests/filesystems/Makefile > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > > CFLAGS += $(KHDR_INCLUDES) > -TEST_GEN_PROGS := devpts_pts file_stressor > +TEST_GEN_PROGS := devpts_pts file_stressor anon_inode_test > TEST_GEN_PROGS_EXTENDED := dnotify_test > > include ../lib.mk > diff --git a/tools/testing/selftests/filesystems/anon_inode_test.c b/tools/testing/selftests/filesystems/anon_inode_test.c > new file mode 100644 > index 000000000000..f2cae8f1ccae > --- /dev/null > +++ b/tools/testing/selftests/filesystems/anon_inode_test.c > @@ -0,0 +1,26 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#define _GNU_SOURCE > +#define __SANE_USERSPACE_TYPES__ > + > +#include <fcntl.h> > +#include <stdio.h> > +#include <sys/stat.h> > + > +#include "../kselftest_harness.h" > +#include "overlayfs/wrappers.h" > + > +TEST(anon_inode_no_chown) > +{ > + int fd_context; > + > + fd_context = sys_fsopen("tmpfs", 0); > + ASSERT_GE(fd_context, 0); > + > + ASSERT_LT(fchown(fd_context, 1234, 5678), 0); > + ASSERT_EQ(errno, EOPNOTSUPP); > + > + EXPECT_EQ(close(fd_context), 0); > +} > + > +TEST_HARNESS_MAIN > + > > -- > 2.47.2 >
diff --git a/tools/testing/selftests/filesystems/.gitignore b/tools/testing/selftests/filesystems/.gitignore index 828b66a10c63..7afa58e2bb20 100644 --- a/tools/testing/selftests/filesystems/.gitignore +++ b/tools/testing/selftests/filesystems/.gitignore @@ -2,3 +2,4 @@ dnotify_test devpts_pts file_stressor +anon_inode_test diff --git a/tools/testing/selftests/filesystems/Makefile b/tools/testing/selftests/filesystems/Makefile index 66305fc34c60..b02326193fee 100644 --- a/tools/testing/selftests/filesystems/Makefile +++ b/tools/testing/selftests/filesystems/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 CFLAGS += $(KHDR_INCLUDES) -TEST_GEN_PROGS := devpts_pts file_stressor +TEST_GEN_PROGS := devpts_pts file_stressor anon_inode_test TEST_GEN_PROGS_EXTENDED := dnotify_test include ../lib.mk diff --git a/tools/testing/selftests/filesystems/anon_inode_test.c b/tools/testing/selftests/filesystems/anon_inode_test.c new file mode 100644 index 000000000000..f2cae8f1ccae --- /dev/null +++ b/tools/testing/selftests/filesystems/anon_inode_test.c @@ -0,0 +1,26 @@ +// SPDX-License-Identifier: GPL-2.0 +#define _GNU_SOURCE +#define __SANE_USERSPACE_TYPES__ + +#include <fcntl.h> +#include <stdio.h> +#include <sys/stat.h> + +#include "../kselftest_harness.h" +#include "overlayfs/wrappers.h" + +TEST(anon_inode_no_chown) +{ + int fd_context; + + fd_context = sys_fsopen("tmpfs", 0); + ASSERT_GE(fd_context, 0); + + ASSERT_LT(fchown(fd_context, 1234, 5678), 0); + ASSERT_EQ(errno, EOPNOTSUPP); + + EXPECT_EQ(close(fd_context), 0); +} + +TEST_HARNESS_MAIN +
Test that anonymous inodes cannot be chown()ed. Signed-off-by: Christian Brauner <brauner@kernel.org> --- tools/testing/selftests/filesystems/.gitignore | 1 + tools/testing/selftests/filesystems/Makefile | 2 +- .../selftests/filesystems/anon_inode_test.c | 26 ++++++++++++++++++++++ 3 files changed, 28 insertions(+), 1 deletion(-)