| Message ID | 20250411-fix_fs-v2-1-5d3395c102e4@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fs: bug fixes | expand |
On Fri 11-04-25 23:31:40, Zijun Hu wrote: > From: Zijun Hu <quic_zijuhu@quicinc.com> > > Delete macro fsparam_u32hex() since: > > - it has no caller. > > - it uses as type @fs_param_is_u32_hex which is never defined, so will > cause compile error when caller uses it. > > Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > Documentation/filesystems/mount_api.rst | 1 - > include/linux/fs_parser.h | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/Documentation/filesystems/mount_api.rst b/Documentation/filesystems/mount_api.rst > index d92c276f1575af11370dcd4a5d5d0ac97c4d7f4c..47dafbb7427e6a829989a815e4d034e48fdbe7a2 100644 > --- a/Documentation/filesystems/mount_api.rst > +++ b/Documentation/filesystems/mount_api.rst > @@ -671,7 +671,6 @@ The members are as follows: > fsparam_bool() fs_param_is_bool > fsparam_u32() fs_param_is_u32 > fsparam_u32oct() fs_param_is_u32_octal > - fsparam_u32hex() fs_param_is_u32_hex > fsparam_s32() fs_param_is_s32 > fsparam_u64() fs_param_is_u64 > fsparam_enum() fs_param_is_enum > diff --git a/include/linux/fs_parser.h b/include/linux/fs_parser.h > index 53e566efd5fd133d19e313e494b975612a227b77..5057faf4f09182fa6e7ddd03fb17b066efd7e58b 100644 > --- a/include/linux/fs_parser.h > +++ b/include/linux/fs_parser.h > @@ -125,8 +125,6 @@ static inline bool fs_validate_description(const char *name, > #define fsparam_u32(NAME, OPT) __fsparam(fs_param_is_u32, NAME, OPT, 0, NULL) > #define fsparam_u32oct(NAME, OPT) \ > __fsparam(fs_param_is_u32, NAME, OPT, 0, (void *)8) > -#define fsparam_u32hex(NAME, OPT) \ > - __fsparam(fs_param_is_u32_hex, NAME, OPT, 0, (void *)16) > #define fsparam_s32(NAME, OPT) __fsparam(fs_param_is_s32, NAME, OPT, 0, NULL) > #define fsparam_u64(NAME, OPT) __fsparam(fs_param_is_u64, NAME, OPT, 0, NULL) > #define fsparam_enum(NAME, OPT, array) __fsparam(fs_param_is_enum, NAME, OPT, 0, array) > > -- > 2.34.1 >
On Fri, 11 Apr 2025 23:31:40 +0800, Zijun Hu wrote: > Delete macro fsparam_u32hex() since: > > - it has no caller. > > - it uses as type @fs_param_is_u32_hex which is never defined, so will > cause compile error when caller uses it. > > [...] Applied to the vfs-6.16.misc branch of the vfs/vfs.git tree. Patches in the vfs-6.16.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs-6.16.misc [1/2] fs/fs_parse: Delete macro fsparam_u32hex() https://git.kernel.org/vfs/vfs/c/8cc42084abd9
diff --git a/Documentation/filesystems/mount_api.rst b/Documentation/filesystems/mount_api.rst index d92c276f1575af11370dcd4a5d5d0ac97c4d7f4c..47dafbb7427e6a829989a815e4d034e48fdbe7a2 100644 --- a/Documentation/filesystems/mount_api.rst +++ b/Documentation/filesystems/mount_api.rst @@ -671,7 +671,6 @@ The members are as follows: fsparam_bool() fs_param_is_bool fsparam_u32() fs_param_is_u32 fsparam_u32oct() fs_param_is_u32_octal - fsparam_u32hex() fs_param_is_u32_hex fsparam_s32() fs_param_is_s32 fsparam_u64() fs_param_is_u64 fsparam_enum() fs_param_is_enum diff --git a/include/linux/fs_parser.h b/include/linux/fs_parser.h index 53e566efd5fd133d19e313e494b975612a227b77..5057faf4f09182fa6e7ddd03fb17b066efd7e58b 100644 --- a/include/linux/fs_parser.h +++ b/include/linux/fs_parser.h @@ -125,8 +125,6 @@ static inline bool fs_validate_description(const char *name, #define fsparam_u32(NAME, OPT) __fsparam(fs_param_is_u32, NAME, OPT, 0, NULL) #define fsparam_u32oct(NAME, OPT) \ __fsparam(fs_param_is_u32, NAME, OPT, 0, (void *)8) -#define fsparam_u32hex(NAME, OPT) \ - __fsparam(fs_param_is_u32_hex, NAME, OPT, 0, (void *)16) #define fsparam_s32(NAME, OPT) __fsparam(fs_param_is_s32, NAME, OPT, 0, NULL) #define fsparam_u64(NAME, OPT) __fsparam(fs_param_is_u64, NAME, OPT, 0, NULL) #define fsparam_enum(NAME, OPT, array) __fsparam(fs_param_is_enum, NAME, OPT, 0, array)