diff mbox series

adfs: delete unused "union adfs_dirtail" definition

Message ID 43b0a4c8-a7cf-4ab1-98f7-0f65c096f9e8@p183 (mailing list archive)
State New, archived
Headers show
Series adfs: delete unused "union adfs_dirtail" definition | expand

Commit Message

Alexey Dobriyan Aug. 9, 2023, 4:35 p.m. UTC
union adfs_dirtail::new stands in the way if Linux++ project:
"new" can't be used as member's name because it is a keyword in C++.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 fs/adfs/dir_f.h |    5 -----
 1 file changed, 5 deletions(-)

Comments

Matthew Wilcox (Oracle) Aug. 9, 2023, 4:46 p.m. UTC | #1
On Wed, Aug 09, 2023 at 07:35:49PM +0300, Alexey Dobriyan wrote:
> union adfs_dirtail::new stands in the way if Linux++ project:
> "new" can't be used as member's name because it is a keyword in C++.

$ git grep '\<new->' fs |wc -l
610

You cannot seriously be proposing this.
Alexey Dobriyan Aug. 9, 2023, 6:01 p.m. UTC | #2
On Wed, Aug 09, 2023 at 05:46:51PM +0100, Matthew Wilcox wrote:
> On Wed, Aug 09, 2023 at 07:35:49PM +0300, Alexey Dobriyan wrote:
> > union adfs_dirtail::new stands in the way if Linux++ project:
> > "new" can't be used as member's name because it is a keyword in C++.
> 
> $ git grep '\<new->' fs |wc -l
> 610
> 
> You cannot seriously be proposing this.

I'm just deleting unused code. :^)

	 1065 files changed, 10454 insertions(+), 10454 deletions(-)
diff mbox series

Patch

--- a/fs/adfs/dir_f.h
+++ b/fs/adfs/dir_f.h
@@ -58,9 +58,4 @@  struct adfs_newdirtail {
 	__u8 dircheckbyte;
 } __attribute__((packed));
 
-union adfs_dirtail {
-	struct adfs_olddirtail old;
-	struct adfs_newdirtail new;
-};
-
 #endif