f2fs: fix defined but not used build warnings

Commit Message

Randy Dunlap July 7, 2018, 3:50 a.m. UTC

From: Randy Dunlap <[e-mail]>

Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled
by marking the unused functions as __maybe_unused.

../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not used [-Wunused-function]
../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not used [-Wunused-function]
../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not used [-Wunused-function]

Signed-off-by: Randy Dunlap <[e-mail]>
Cc: Jaegeuk Kim <[e-mail]>
Cc: Chao Yu <[e-mail]>
Cc: [e-mail]
---
 fs/f2fs/sysfs.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Chao Yu July 10, 2018, 1:09 a.m. UTC | #1

On 2018/7/7 11:50, Randy Dunlap wrote:
> From: Randy Dunlap <[e-mail]>
> 
> Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled
> by marking the unused functions as __maybe_unused.
> 
> ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not used [-Wunused-function]
> ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not used [-Wunused-function]
> ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not used [-Wunused-function]
> 
> Signed-off-by: Randy Dunlap <[e-mail]>
> Cc: Jaegeuk Kim <[e-mail]>
> Cc: Chao Yu <[e-mail]>
> Cc: [e-mail]

Reviewed-by: Chao Yu <[e-mail]>

Thanks,

Randy Dunlap July 12, 2018, 3:35 a.m. UTC | #2

On 07/09/2018 06:09 PM, Chao Yu wrote:
> On 2018/7/7 11:50, Randy Dunlap wrote:
>> From: Randy Dunlap <[e-mail]>
>>
>> Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled
>> by marking the unused functions as __maybe_unused.
>>
>> ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not used [-Wunused-function]
>> ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not used [-Wunused-function]
>> ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not used [-Wunused-function]
>>
>> Signed-off-by: Randy Dunlap <[e-mail]>
>> Cc: Jaegeuk Kim <[e-mail]>
>> Cc: Chao Yu <[e-mail]>
>> Cc: [e-mail]
> 
> Reviewed-by: Chao Yu <[e-mail]>

Hi,
Who would you like to merge this patch?  or could you do so?

thanks,

Jaegeuk Kim July 12, 2018, 4:15 a.m. UTC | #3

On 07/11, Randy Dunlap wrote:
> On 07/09/2018 06:09 PM, Chao Yu wrote:
> > On 2018/7/7 11:50, Randy Dunlap wrote:
> >> From: Randy Dunlap <[e-mail]>
> >>
> >> Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled
> >> by marking the unused functions as __maybe_unused.
> >>
> >> ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not used [-Wunused-function]
> >> ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not used [-Wunused-function]
> >> ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not used [-Wunused-function]
> >>
> >> Signed-off-by: Randy Dunlap <[e-mail]>
> >> Cc: Jaegeuk Kim <[e-mail]>
> >> Cc: Chao Yu <[e-mail]>
> >> Cc: [e-mail]
> > 
> > Reviewed-by: Chao Yu <[e-mail]>
> 
> Hi,
> Who would you like to merge this patch?  or could you do so?

Hi Randy,

I'll merge it in -next for Linus.

Thanks,

> 
> thanks,
> -- 
> ~Randy

Chao Yu July 12, 2018, 8:21 a.m. UTC | #4

On 2018/7/12 11:35, Randy Dunlap wrote:
> On 07/09/2018 06:09 PM, Chao Yu wrote:
>> On 2018/7/7 11:50, Randy Dunlap wrote:
>>> From: Randy Dunlap <[e-mail]>
>>>
>>> Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled
>>> by marking the unused functions as __maybe_unused.
>>>
>>> ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not used [-Wunused-function]
>>> ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not used [-Wunused-function]
>>> ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not used [-Wunused-function]
>>>
>>> Signed-off-by: Randy Dunlap <[e-mail]>
>>> Cc: Jaegeuk Kim <[e-mail]>
>>> Cc: Chao Yu <[e-mail]>
>>> Cc: [e-mail]
>>
>> Reviewed-by: Chao Yu <[e-mail]>
> 
> Hi,
> Who would you like to merge this patch?  or could you do so?

Hello,

Jaegeuk will merge it. :)

Thanks,

> 
> thanks,
>

Patch

--- linux-next-20180706.orig/fs/f2fs/sysfs.c
+++ linux-next-20180706/fs/f2fs/sysfs.c
@@ -9,6 +9,7 @@ 
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
  */
+#include <linux/compiler.h>
 #include <linux/proc_fs.h>
 #include <linux/f2fs_fs.h>
 #include <linux/seq_file.h>
@@ -516,7 +517,8 @@  static struct kobject f2fs_feat = {
 	.kset	= &f2fs_kset,
 };
 
-static int segment_info_seq_show(struct seq_file *seq, void *offset)
+static int __maybe_unused segment_info_seq_show(struct seq_file *seq,
+						void *offset)
 {
 	struct super_block *sb = seq->private;
 	struct f2fs_sb_info *sbi = F2FS_SB(sb);
@@ -543,7 +545,8 @@  static int segment_info_seq_show(struct
 	return 0;
 }
 
-static int segment_bits_seq_show(struct seq_file *seq, void *offset)
+static int __maybe_unused segment_bits_seq_show(struct seq_file *seq,
+						void *offset)
 {
 	struct super_block *sb = seq->private;
 	struct f2fs_sb_info *sbi = F2FS_SB(sb);
@@ -567,7 +570,8 @@  static int segment_bits_seq_show(struct
 	return 0;
 }
 
-static int iostat_info_seq_show(struct seq_file *seq, void *offset)
+static int __maybe_unused iostat_info_seq_show(struct seq_file *seq,
+					       void *offset)
 {
 	struct super_block *sb = seq->private;
 	struct f2fs_sb_info *sbi = F2FS_SB(sb);