| Message ID | 58eee51755bb15c312c9d5935655a89466bd34ca.1587555962.git.riteshh@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ext4/overlayfs: fiemap related fixes | expand |
On Thu 23-04-20 16:17:55, Ritesh Harjani wrote: > 1. fiemap_check_ranges() is needed by ovl_fiemap() to check for ranges > before calling underlying inode's ->fiemap() call. > 2. With this change even ext4 can use generic fiemap_check_ranges() instead of > having a duplicate copy of it. > > So make this EXPORT_SYMBOL for use by overlayfs. > > Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> Looks good to me. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/ioctl.c | 5 +++-- > include/linux/fs.h | 2 ++ > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/fs/ioctl.c b/fs/ioctl.c > index 282d45be6f45..f1d93263186c 100644 > --- a/fs/ioctl.c > +++ b/fs/ioctl.c > @@ -166,8 +166,8 @@ int fiemap_check_flags(struct fiemap_extent_info *fieinfo, u32 fs_flags) > } > EXPORT_SYMBOL(fiemap_check_flags); > > -static int fiemap_check_ranges(struct super_block *sb, > - u64 start, u64 len, u64 *new_len) > +int fiemap_check_ranges(struct super_block *sb, u64 start, u64 len, > + u64 *new_len) > { > u64 maxbytes = (u64) sb->s_maxbytes; > > @@ -187,6 +187,7 @@ static int fiemap_check_ranges(struct super_block *sb, > > return 0; > } > +EXPORT_SYMBOL(fiemap_check_ranges); > > static int ioctl_fiemap(struct file *filp, struct fiemap __user *ufiemap) > { > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 4f6f59b4f22a..1ea70fe07618 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1759,6 +1759,8 @@ int fiemap_fill_next_extent(struct fiemap_extent_info *info, u64 logical, > u64 phys, u64 len, u32 flags); > int fiemap_check_flags(struct fiemap_extent_info *fieinfo, u32 fs_flags); > > +int fiemap_check_ranges(struct super_block *sb, u64 start, u64 len, > + u64 *new_len); > /* > * This is the "filldir" function type, used by readdir() to let > * the kernel specify what kind of dirent layout it wants to have. > -- > 2.21.0 >
diff --git a/fs/ioctl.c b/fs/ioctl.c index 282d45be6f45..f1d93263186c 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@ -166,8 +166,8 @@ int fiemap_check_flags(struct fiemap_extent_info *fieinfo, u32 fs_flags) } EXPORT_SYMBOL(fiemap_check_flags); -static int fiemap_check_ranges(struct super_block *sb, - u64 start, u64 len, u64 *new_len) +int fiemap_check_ranges(struct super_block *sb, u64 start, u64 len, + u64 *new_len) { u64 maxbytes = (u64) sb->s_maxbytes; @@ -187,6 +187,7 @@ static int fiemap_check_ranges(struct super_block *sb, return 0; } +EXPORT_SYMBOL(fiemap_check_ranges); static int ioctl_fiemap(struct file *filp, struct fiemap __user *ufiemap) { diff --git a/include/linux/fs.h b/include/linux/fs.h index 4f6f59b4f22a..1ea70fe07618 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1759,6 +1759,8 @@ int fiemap_fill_next_extent(struct fiemap_extent_info *info, u64 logical, u64 phys, u64 len, u32 flags); int fiemap_check_flags(struct fiemap_extent_info *fieinfo, u32 fs_flags); +int fiemap_check_ranges(struct super_block *sb, u64 start, u64 len, + u64 *new_len); /* * This is the "filldir" function type, used by readdir() to let * the kernel specify what kind of dirent layout it wants to have.
1. fiemap_check_ranges() is needed by ovl_fiemap() to check for ranges before calling underlying inode's ->fiemap() call. 2. With this change even ext4 can use generic fiemap_check_ranges() instead of having a duplicate copy of it. So make this EXPORT_SYMBOL for use by overlayfs. Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> --- fs/ioctl.c | 5 +++-- include/linux/fs.h | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-)