From patchwork Mon Jul 3 07:33:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Konstantin Komarov X-Patchwork-Id: 13299658 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D85CEB64DC for ; Mon, 3 Jul 2023 07:33:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231164AbjGCHdw (ORCPT ); Mon, 3 Jul 2023 03:33:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231159AbjGCHdq (ORCPT ); Mon, 3 Jul 2023 03:33:46 -0400 Received: from relayaws-01.paragon-software.com (relayaws-01.paragon-software.com [35.157.23.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCB7DE52; Mon, 3 Jul 2023 00:33:45 -0700 (PDT) Received: from relayfre-01.paragon-software.com (unknown [172.30.72.12]) by relayaws-01.paragon-software.com (Postfix) with ESMTPS id 7288A1D2D; Mon, 3 Jul 2023 07:28:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paragon-software.com; s=mail; t=1688369312; bh=vyFL1oZhfU5xO720PsZEshxb54c3khK1/6rIHMavdPI=; h=Date:To:CC:From:Subject; b=uOhK/kSSM6jkXirF69xA1s7lI7dreMO3txzGArfuqppEp4wtSSKADULERPejg29Bm QjmaEVbhj8CFldZIBrA0EpnM2JBZfc+Hyc5LNA8RcjbiPZeMYxCnt5wmNB0LSifyr0 5eFrTLYpXCTr4H/KE0SFl7Bnp3UN2AefFxVAxW1s= Received: from dlg2.mail.paragon-software.com (vdlg-exch-02.paragon-software.com [172.30.1.105]) by relayfre-01.paragon-software.com (Postfix) with ESMTPS id E6539439; Mon, 3 Jul 2023 07:33:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paragon-software.com; s=mail; t=1688369623; bh=vyFL1oZhfU5xO720PsZEshxb54c3khK1/6rIHMavdPI=; h=Date:To:CC:From:Subject; b=QM8izealV0gY8ReiLgWMkj4fwLg19nsJU9F1M4IIJf/KJQwzKK5YVeAtdKtOHZirI L7pxwKyW/FDF2b4ror+a0Np/uF+VIlZMxpoxeFamamlpaQw5W6CMD6jgc0zPs2rx52 USb/HzLlpHam/MOz4K02x77DYYGN8/aVe8OG5r9g= Received: from [192.168.211.138] (192.168.211.138) by vdlg-exch-02.paragon-software.com (172.30.1.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Mon, 3 Jul 2023 10:33:43 +0300 Message-ID: <5ce7410b-3715-dabb-0135-139f86546337@paragon-software.com> Date: Mon, 3 Jul 2023 11:33:42 +0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: CC: Linux Kernel Mailing List , , From: Konstantin Komarov Subject: [PATCH] fs/ntfs3: Correct mode for label entry inside /proc/fs/ntfs3/ X-Originating-IP: [192.168.211.138] X-ClientProxiedBy: vdlg-exch-02.paragon-software.com (172.30.1.105) To vdlg-exch-02.paragon-software.com (172.30.1.105) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Suggested-by: Dan Carpenter Signed-off-by: Konstantin Komarov ---  fs/ntfs3/super.c | 7 ++++---  1 file changed, 4 insertions(+), 3 deletions(-)      } diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index e36769eac7de..1a02072b6b0e 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -1548,11 +1548,12 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)      /* Create /proc/fs/ntfs3/.. */      if (proc_info_root) {          struct proc_dir_entry *e = proc_mkdir(sb->s_id, proc_info_root); +        static_assert((S_IRUGO | S_IWUSR) == 0644);          if (e) { -            proc_create_data("volinfo", S_IFREG | S_IRUGO, e, +            proc_create_data("volinfo", S_IRUGO, e,                       &ntfs3_volinfo_fops, sb); -            proc_create_data("label", S_IFREG | S_IRUGO | S_IWUGO, -                     e, &ntfs3_label_fops, sb); +            proc_create_data("label", S_IRUGO | S_IWUSR, e, +                     &ntfs3_label_fops, sb);              sbi->procdir = e;          }