| Message ID | 633c251a-b548-4428-9e91-1cf8147d8c55@p183 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fanotify: delete useless parenthesis in FANOTIFY_INLINE_FH macro | expand |
On Tue 10-10-23 14:44:35, Alexey Dobriyan wrote: > Parenthesis around identifier name in declaration are useless. > This is just "put every macro argument inside parenthesis" practice. > > Now "size" must be constant expression, but using comma expression in > constant expression is useless too, therefore [] will guard "size" > expression just as well as (). > > Also g++ is somewhat upset about these: > > fs/notify/fanotify/fanotify.h:278:28: warning: unnecessary parentheses in declaration of ‘object_fh’ [-Wparentheses] > 278 | struct fanotify_fh (name); > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Yeah, ok. Added to my tree. Thanks! Honza > --- > > fs/notify/fanotify/fanotify.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/fs/notify/fanotify/fanotify.h > +++ b/fs/notify/fanotify/fanotify.h > @@ -275,9 +275,9 @@ static inline void fanotify_init_event(struct fanotify_event *event, > > #define FANOTIFY_INLINE_FH(name, size) \ > struct { \ > - struct fanotify_fh (name); \ > + struct fanotify_fh name; \ > /* Space for object_fh.buf[] - access with fanotify_fh_buf() */ \ > - unsigned char _inline_fh_buf[(size)]; \ > + unsigned char _inline_fh_buf[size]; \ > } > > struct fanotify_fid_event {
--- a/fs/notify/fanotify/fanotify.h +++ b/fs/notify/fanotify/fanotify.h @@ -275,9 +275,9 @@ static inline void fanotify_init_event(struct fanotify_event *event, #define FANOTIFY_INLINE_FH(name, size) \ struct { \ - struct fanotify_fh (name); \ + struct fanotify_fh name; \ /* Space for object_fh.buf[] - access with fanotify_fh_buf() */ \ - unsigned char _inline_fh_buf[(size)]; \ + unsigned char _inline_fh_buf[size]; \ } struct fanotify_fid_event {
Parenthesis around identifier name in declaration are useless. This is just "put every macro argument inside parenthesis" practice. Now "size" must be constant expression, but using comma expression in constant expression is useless too, therefore [] will guard "size" expression just as well as (). Also g++ is somewhat upset about these: fs/notify/fanotify/fanotify.h:278:28: warning: unnecessary parentheses in declaration of ‘object_fh’ [-Wparentheses] 278 | struct fanotify_fh (name); Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> --- fs/notify/fanotify/fanotify.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)