| Message ID | 6448e3adc13eff8b152f7954c838eb9315c91574.1733902742.git.ojaswin@linux.ibm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | xfs_io: enable extsize and stat -v support for ext4 | expand |
On Wed, Dec 11, 2024 at 01:24:04PM +0530, Ojaswin Mujoo wrote: > extsize command is currently only supported with XFS filesystem. > Lift this restriction now that ext4 is also supporting extsize hints. > > Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com> Seems pretty straightforward to me. Are you planning to add an extsize option to chattr? Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> --D > --- > io/open.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/io/open.c b/io/open.c > index a30dd89a1fd5..2582ff9b862e 100644 > --- a/io/open.c > +++ b/io/open.c > @@ -997,7 +997,7 @@ open_init(void) > extsize_cmd.args = _("[-D | -R] [extsize]"); > extsize_cmd.argmin = 0; > extsize_cmd.argmax = -1; > - extsize_cmd.flags = CMD_NOMAP_OK; > + extsize_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK; > extsize_cmd.oneline = > _("get/set preferred extent size (in bytes) for the open file"); > extsize_cmd.help = extsize_help; > -- > 2.43.5 > >
On Wed, Dec 11, 2024 at 10:18:27AM -0800, Darrick J. Wong wrote: > On Wed, Dec 11, 2024 at 01:24:04PM +0530, Ojaswin Mujoo wrote: > > extsize command is currently only supported with XFS filesystem. > > Lift this restriction now that ext4 is also supporting extsize hints. > > > > Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com> > > Seems pretty straightforward to me. Are you planning to add an extsize > option to chattr? Do you mean e2fsprogs? If so, then yes we'll add it there eventually however for now I only have xfs_io patches since I was working on them to make the extsize xfstests work with ext4. Regards, ojaswin > > Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> > > --D > > > --- > > io/open.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/io/open.c b/io/open.c > > index a30dd89a1fd5..2582ff9b862e 100644 > > --- a/io/open.c > > +++ b/io/open.c > > @@ -997,7 +997,7 @@ open_init(void) > > extsize_cmd.args = _("[-D | -R] [extsize]"); > > extsize_cmd.argmin = 0; > > extsize_cmd.argmax = -1; > > - extsize_cmd.flags = CMD_NOMAP_OK; > > + extsize_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK; > > extsize_cmd.oneline = > > _("get/set preferred extent size (in bytes) for the open file"); > > extsize_cmd.help = extsize_help; > > -- > > 2.43.5 > > > >
On Thu, Dec 12, 2024 at 05:34:17PM +0530, Ojaswin Mujoo wrote: > On Wed, Dec 11, 2024 at 10:18:27AM -0800, Darrick J. Wong wrote: > > On Wed, Dec 11, 2024 at 01:24:04PM +0530, Ojaswin Mujoo wrote: > > > extsize command is currently only supported with XFS filesystem. > > > Lift this restriction now that ext4 is also supporting extsize hints. > > > > > > Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com> > > > > Seems pretty straightforward to me. Are you planning to add an extsize > > option to chattr? > > Do you mean e2fsprogs? If so, then yes we'll add it there eventually > however for now I only have xfs_io patches since I was working on them > to make the extsize xfstests work with ext4. Yep, and good to know (about adding chattr support eventually). --D > Regards, > ojaswin > > > > Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> > > > > --D > > > > > --- > > > io/open.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/io/open.c b/io/open.c > > > index a30dd89a1fd5..2582ff9b862e 100644 > > > --- a/io/open.c > > > +++ b/io/open.c > > > @@ -997,7 +997,7 @@ open_init(void) > > > extsize_cmd.args = _("[-D | -R] [extsize]"); > > > extsize_cmd.argmin = 0; > > > extsize_cmd.argmax = -1; > > > - extsize_cmd.flags = CMD_NOMAP_OK; > > > + extsize_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK; > > > extsize_cmd.oneline = > > > _("get/set preferred extent size (in bytes) for the open file"); > > > extsize_cmd.help = extsize_help; > > > -- > > > 2.43.5 > > > > > > >
diff --git a/io/open.c b/io/open.c index a30dd89a1fd5..2582ff9b862e 100644 --- a/io/open.c +++ b/io/open.c @@ -997,7 +997,7 @@ open_init(void) extsize_cmd.args = _("[-D | -R] [extsize]"); extsize_cmd.argmin = 0; extsize_cmd.argmax = -1; - extsize_cmd.flags = CMD_NOMAP_OK; + extsize_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK; extsize_cmd.oneline = _("get/set preferred extent size (in bytes) for the open file"); extsize_cmd.help = extsize_help;
extsize command is currently only supported with XFS filesystem. Lift this restriction now that ext4 is also supporting extsize hints. Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com> --- io/open.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)