diff mbox series

fuse: cleanup fuse_wait_on_page_writeback

Message ID 64e2db3a-cf58-0158-e097-1a504a8bb496@virtuozzo.com (mailing list archive)
State New, archived
Headers show
Series fuse: cleanup fuse_wait_on_page_writeback | expand

Commit Message

Vasily Averin July 22, 2019, 7:17 a.m. UTC 
From: Maxim Patlasov <mpatlasov@virtuozzo.com>
fuse_wait_on_page_writeback() always returns zero and nobody cares.
Let's make it void.

Signed-off-by: Maxim Patlasov <mpatlasov@virtuozzo.com>
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
---
 fs/fuse/file.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Vasily Averin July 22, 2019, 7:18 a.m. UTC | #1 
I forget to add this patch was used in OpenVZ kernels last few years.

On 7/22/19 10:17 AM, Vasily Averin wrote:
> From: Maxim Patlasov <mpatlasov@virtuozzo.com>
> fuse_wait_on_page_writeback() always returns zero and nobody cares.
> Let's make it void.
> 
> Signed-off-by: Maxim Patlasov <mpatlasov@virtuozzo.com>
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
> ---
>  fs/fuse/file.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 5ae2828beb00..e076c2cf65b0 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -383,12 +383,11 @@ static inline bool fuse_page_is_writeback(struct inode *inode, pgoff_t index)
>   * Since fuse doesn't rely on the VM writeback tracking, this has to
>   * use some other means.
>   */
> -static int fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
> +static void fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
>  {
>  	struct fuse_inode *fi = get_fuse_inode(inode);
>  
>  	wait_event(fi->page_waitq, !fuse_page_is_writeback(inode, index));
> -	return 0;
>  }
>  
>  /*
>
Miklos Szeredi Aug. 1, 2019, 11:03 a.m. UTC | #2 
On Mon, Jul 22, 2019 at 9:17 AM Vasily Averin <vvs@virtuozzo.com> wrote:
>
> From: Maxim Patlasov <mpatlasov@virtuozzo.com>
> fuse_wait_on_page_writeback() always returns zero and nobody cares.
> Let's make it void.

Applied.

Thanks,
Miklos
diff mbox series

Patch

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 5ae2828beb00..e076c2cf65b0 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -383,12 +383,11 @@  static inline bool fuse_page_is_writeback(struct inode *inode, pgoff_t index)
  * Since fuse doesn't rely on the VM writeback tracking, this has to
  * use some other means.
  */
-static int fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
+static void fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
 {
 	struct fuse_inode *fi = get_fuse_inode(inode);
 
 	wait_event(fi->page_waitq, !fuse_page_is_writeback(inode, index));
-	return 0;
 }
 
 /*