From patchwork Wed Jul 12 21:40:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jay Lan X-Patchwork-Id: 9837451 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C54B9602D8 for ; Wed, 12 Jul 2017 21:49:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B4DBC28517 for ; Wed, 12 Jul 2017 21:49:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A94FD28550; Wed, 12 Jul 2017 21:49:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2741228517 for ; Wed, 12 Jul 2017 21:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754229AbdGLVtD (ORCPT ); Wed, 12 Jul 2017 17:49:03 -0400 Received: from NDMSVNPF104.ndc.nasa.gov ([198.117.0.154]:57816 "EHLO ndmsvnpf104.ndc.nasa.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754055AbdGLVtD (ORCPT ); Wed, 12 Jul 2017 17:49:03 -0400 X-Greylist: delayed 529 seconds by postgrey-1.27 at vger.kernel.org; Wed, 12 Jul 2017 17:49:02 EDT X-Comment: SPF check N/A for local connections - client-ip=198.117.0.49; helo=ndmsppt204.ndc.nasa.gov; envelope-from=jay.j.lan@nasa.gov; receiver=linux-fsdevel@vger.kernel.org DKIM-Filter: OpenDKIM Filter v2.11.0 ndmsvnpf104.ndc.nasa.gov DDC394005325 Received: from ndmsppt204.ndc.nasa.gov (NDMSPPT204.ndc.nasa.gov [198.117.0.49]) by ndmsvnpf104.ndc.nasa.gov (Postfix) with ESMTP id DDC394005325 for ; Wed, 12 Jul 2017 16:40:12 -0500 (CDT) Received: from pps.filterd (ndmsppt204.ndc.nasa.gov [127.0.0.1]) by ndmsppt204.ndc.nasa.gov (8.16.0.20/8.16.0.20) with SMTP id v6CLZerE161368 for ; Wed, 12 Jul 2017 16:40:12 -0500 Received: from ndmscht113.ndc.nasa.gov (ndmscht113-pub.ndc.nasa.gov [198.117.0.213]) by ndmsppt204.ndc.nasa.gov with ESMTP id 2bnqbp1ytm-1 for ; Wed, 12 Jul 2017 16:40:12 -0500 Received: from linux143.nas.nasa.gov (129.99.133.43) by smtp02.ndc.nasa.gov (198.117.0.213) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 12 Jul 2017 16:40:12 -0500 To: From: Jay Lan Subject: [PATCH] export symbol mount_lock Message-ID: <855c5c7d-586a-3b35-76f8-ddca4fae1410@nasa.gov> Date: Wed, 12 Jul 2017 14:40:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 Content-Language: en-GB X-Originating-IP: [129.99.133.43] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-07-12_06:, , signatures=0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi all, I was writing a livepatch patch, but compilation failed in creating the .ko because mount_lock is "undefined." The mount_lock is defined globally in fs/namespace.c __cacheline_aligned_in_smp DEFINE_SEQLOCK(mount_lock); and extern in fs/mount.h. extern seqlock_t mount_lock; If there is a reason that mount_lock should not be EXPORT_SYMBOL_GPL, please advise; otherwise, I propose the patch to export this symbol. Signed-off-by: Jay Lan --- fs/namespace.c | 1 + 1 file changed, 1 insertion(+) { diff --git a/fs/namespace.c b/fs/namespace.c index 5a4438445bf7..3bbb619391ce 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -83,6 +83,7 @@ EXPORT_SYMBOL_GPL(fs_kobj); * tree or hash is modified or when a vfsmount structure is modified. */ __cacheline_aligned_in_smp DEFINE_SEQLOCK(mount_lock); +EXPORT_SYMBOL_GPL(mount_lock); static inline struct hlist_head *m_hash(struct vfsmount *mnt, struct dentry *dentry)