mbox series

[GIT,PULL] xfs: bug fixes for 6.7

Message ID 87zfzb31yl.fsf@debian-BULLSEYE-live-builder-AMD64 (mailing list archive)
State New
Headers show
Series [GIT,PULL] xfs: bug fixes for 6.7 | expand

Pull-request

https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/xfs-6.7-fixes-1

Message

Chandan Babu R Nov. 18, 2023, 8:16 a.m. UTC
Hi Linus,

Please pull this branch with changes for xfs for 6.7-rc2. The changes are
limited to only bug fixes whose summary is provided below.

I did a test-merge with the main upstream branch as of a few minutes ago and
didn't see any conflicts.  Please let me know if you encounter any problems.

The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86:

  Linux 6.7-rc1 (2023-11-12 16:19:07 -0800)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/xfs-6.7-fixes-1

for you to fetch changes up to 7930d9e103700cde15833638855b750715c12091:

  xfs: recovery should not clear di_flushiter unconditionally (2023-11-13 09:11:41 +0530)

----------------------------------------------------------------
Bug fixes for 6.7-rc2:

 * Fix deadlock arising due to intent items in AIL not being cleared when log
   recovery fails.
 * Fix stale data exposure bug when remapping COW fork extents to data fork.
 * Fix deadlock when data device flush fails.
 * Fix AGFL minimum size calculation.
 * Select DEBUG_FS instead of XFS_DEBUG when XFS_ONLINE_SCRUB_STATS is
   selected.
 * Fix corruption of log inode's extent count field when NREXT64 feature is
 enabled.

Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>

----------------------------------------------------------------
Anthony Iliopoulos (1):
      xfs: fix again select in kconfig XFS_ONLINE_SCRUB_STATS

Christoph Hellwig (1):
      xfs: only remap the written blocks in xfs_reflink_end_cow_extent

Dave Chinner (2):
      xfs: inode recovery does not validate the recovered inode
      xfs: recovery should not clear di_flushiter unconditionally

Leah Rumancik (1):
      xfs: up(ic_sema) if flushing data device fails

Long Li (2):
      xfs: factor out xfs_defer_pending_abort
      xfs: abort intent items when recovery intents fail

Matthew Wilcox (Oracle) (1):
      XFS: Update MAINTAINERS to catch all XFS documentation

Omar Sandoval (1):
      xfs: fix internal error from AGFL exhaustion

 MAINTAINERS                     |  3 +--
 fs/xfs/Kconfig                  |  2 +-
 fs/xfs/libxfs/xfs_alloc.c       | 27 +++++++++++++++++++++---
 fs/xfs/libxfs/xfs_defer.c       | 28 ++++++++++++++++---------
 fs/xfs/libxfs/xfs_defer.h       |  2 +-
 fs/xfs/libxfs/xfs_inode_buf.c   |  3 +++
 fs/xfs/xfs_inode_item_recover.c | 46 +++++++++++++++++++++++++++--------------
 fs/xfs/xfs_log.c                | 23 +++++++++++----------
 fs/xfs/xfs_log_recover.c        |  2 +-
 fs/xfs/xfs_reflink.c            |  1 +
 10 files changed, 92 insertions(+), 45 deletions(-)

Comments

Linus Torvalds Nov. 18, 2023, 7:41 p.m. UTC | #1
On Sat, 18 Nov 2023 at 00:22, Chandan Babu R <chandanbabu@kernel.org> wrote:
>
> Matthew Wilcox (Oracle) (1):
>       XFS: Update MAINTAINERS to catch all XFS documentation

I have no complaints about this change, but I did have a reaction:
should that "Documentation/filesystems" directory hierarchy maybe be
cleaned up a bit?

IOW, instead of the "xfs-*" pattern, just do subdirectories for
filesystems that have enough documentation that they do multiple
files?

I see that ext4, smb and spufs already do exactly that. And a few
other filesystems maybe should move that way, and xfs would seem to be
the obvious next one.

Not a big deal, but that file pattern change did make me go "humm".

So particularly if somebody ends up (for example) splitting that big
online fsck doc up some day, please just give xfs a subdirectory of
its own at the same time?

            Linus
pr-tracker-bot@kernel.org Nov. 18, 2023, 7:45 p.m. UTC | #2
The pull request you sent on Sat, 18 Nov 2023 13:46:27 +0530:

> https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/xfs-6.7-fixes-1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/b8f1fa2419c19c81bc386a6b350879ba54a573e1

Thank you!
Chandan Babu R Nov. 19, 2023, 1:35 p.m. UTC | #3
On Sat, Nov 18, 2023 at 11:41:36 AM -0800, Linus Torvalds wrote:
> On Sat, 18 Nov 2023 at 00:22, Chandan Babu R <chandanbabu@kernel.org> wrote:
>>
>> Matthew Wilcox (Oracle) (1):
>>       XFS: Update MAINTAINERS to catch all XFS documentation
>
> I have no complaints about this change, but I did have a reaction:
> should that "Documentation/filesystems" directory hierarchy maybe be
> cleaned up a bit?
>
> IOW, instead of the "xfs-*" pattern, just do subdirectories for
> filesystems that have enough documentation that they do multiple
> files?
>
> I see that ext4, smb and spufs already do exactly that. And a few
> other filesystems maybe should move that way, and xfs would seem to be
> the obvious next one.
>
> Not a big deal, but that file pattern change did make me go "humm".
>
> So particularly if somebody ends up (for example) splitting that big
> online fsck doc up some day, please just give xfs a subdirectory of
> its own at the same time?

I agree with your suggestion. I will make sure that new files documenting XFS
will be created in a new directory that is specific to XFS and existing
documentation will be moved under the new directory.