| Message ID | 9cc1f9ac12ff3dca6b0c18d0bda2245a1264595e.1645558375.git.riteshh@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ext4: Improve FC trace events and discuss one FC failure | expand |
On Wed 23-02-22 02:04:15, Ritesh Harjani wrote: > All ext4 & jbd2 trace events starts with "dev Major:Minor". > While we are still improving/adding the ftrace events for FC, > let's fix last two remaining trace events to follow the same > convention. > > Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> OK. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > include/trace/events/ext4.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h > index 6e66cb7ce624..233dbffa5ceb 100644 > --- a/include/trace/events/ext4.h > +++ b/include/trace/events/ext4.h > @@ -2653,7 +2653,7 @@ TRACE_EVENT(ext4_fc_replay_scan, > __entry->off = off; > ), > > - TP_printk("FC scan pass on dev %d,%d: error %d, off %d", > + TP_printk("dev %d,%d error %d, off %d", > MAJOR(__entry->dev), MINOR(__entry->dev), > __entry->error, __entry->off) > ); > @@ -2679,7 +2679,7 @@ TRACE_EVENT(ext4_fc_replay, > __entry->priv2 = priv2; > ), > > - TP_printk("FC Replay %d,%d: tag %d, ino %d, data1 %d, data2 %d", > + TP_printk("dev %d,%d: tag %d, ino %d, data1 %d, data2 %d", > MAJOR(__entry->dev), MINOR(__entry->dev), > __entry->tag, __entry->ino, __entry->priv1, __entry->priv2) > ); > -- > 2.31.1 >
Looks good. Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com> - Harshad On Wed, 23 Feb 2022 at 01:45, Jan Kara <jack@suse.cz> wrote: > > On Wed 23-02-22 02:04:15, Ritesh Harjani wrote: > > All ext4 & jbd2 trace events starts with "dev Major:Minor". > > While we are still improving/adding the ftrace events for FC, > > let's fix last two remaining trace events to follow the same > > convention. > > > > Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> > > OK. Feel free to add: > > Reviewed-by: Jan Kara <jack@suse.cz> > > Honza > > > --- > > include/trace/events/ext4.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h > > index 6e66cb7ce624..233dbffa5ceb 100644 > > --- a/include/trace/events/ext4.h > > +++ b/include/trace/events/ext4.h > > @@ -2653,7 +2653,7 @@ TRACE_EVENT(ext4_fc_replay_scan, > > __entry->off = off; > > ), > > > > - TP_printk("FC scan pass on dev %d,%d: error %d, off %d", > > + TP_printk("dev %d,%d error %d, off %d", > > MAJOR(__entry->dev), MINOR(__entry->dev), > > __entry->error, __entry->off) > > ); > > @@ -2679,7 +2679,7 @@ TRACE_EVENT(ext4_fc_replay, > > __entry->priv2 = priv2; > > ), > > > > - TP_printk("FC Replay %d,%d: tag %d, ino %d, data1 %d, data2 %d", > > + TP_printk("dev %d,%d: tag %d, ino %d, data1 %d, data2 %d", > > MAJOR(__entry->dev), MINOR(__entry->dev), > > __entry->tag, __entry->ino, __entry->priv1, __entry->priv2) > > ); > > -- > > 2.31.1 > > > -- > Jan Kara <jack@suse.com> > SUSE Labs, CR
diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h index 6e66cb7ce624..233dbffa5ceb 100644 --- a/include/trace/events/ext4.h +++ b/include/trace/events/ext4.h @@ -2653,7 +2653,7 @@ TRACE_EVENT(ext4_fc_replay_scan, __entry->off = off; ), - TP_printk("FC scan pass on dev %d,%d: error %d, off %d", + TP_printk("dev %d,%d error %d, off %d", MAJOR(__entry->dev), MINOR(__entry->dev), __entry->error, __entry->off) ); @@ -2679,7 +2679,7 @@ TRACE_EVENT(ext4_fc_replay, __entry->priv2 = priv2; ), - TP_printk("FC Replay %d,%d: tag %d, ino %d, data1 %d, data2 %d", + TP_printk("dev %d,%d: tag %d, ino %d, data1 %d, data2 %d", MAJOR(__entry->dev), MINOR(__entry->dev), __entry->tag, __entry->ino, __entry->priv1, __entry->priv2) );
All ext4 & jbd2 trace events starts with "dev Major:Minor". While we are still improving/adding the ftrace events for FC, let's fix last two remaining trace events to follow the same convention. Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> --- include/trace/events/ext4.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)