From patchwork Thu Jan 14 19:15:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomeu Vizoso X-Patchwork-Id: 8035081 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 128D49F716 for ; Thu, 14 Jan 2016 19:16:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 36EC120445 for ; Thu, 14 Jan 2016 19:16:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 492A12040F for ; Thu, 14 Jan 2016 19:16:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756819AbcANTQV (ORCPT ); Thu, 14 Jan 2016 14:16:21 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:35675 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754011AbcANTQU (ORCPT ); Thu, 14 Jan 2016 14:16:20 -0500 Received: by mail-wm0-f54.google.com with SMTP id f206so359351448wmf.0 for ; Thu, 14 Jan 2016 11:16:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tomeuvizoso-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=P9s+2TDnLAgziYvQTm52JTt8MJ98huqLlgaMxt73X3s=; b=EZkQD3gxjqYaD5F8TQHz064K4PkZK8Oybbr8SwxT0RtZxZ/sxWUL4ao6RYkQzF9Csf 7NiGDfvJgZi2MnzIHc+zEXy0C9P7qGe1A+JcRc6YvxZKe6bdbc3vLsllwMdJq2D92+N2 ySTyMaOO12aNxG6I+az48Bqap0PPH+SDDuRI5I9aoaD5d0eHdGALiA4fdLfvBnDxbTdI DtG/cmUxRUOficm8gsSgY9x7OkdW04Irf00b4IMKSdY6pcDeeyQX78i5R01Wf2PwglFs 6BhoShSBvuBQOB2Lc7vrricnWYgXGA/Cn9RloRhj0aTmDmuoqFSPHiEn4YAa59U25p4Z LrcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=P9s+2TDnLAgziYvQTm52JTt8MJ98huqLlgaMxt73X3s=; b=ftJbC+dN7h9lOforHDPgARqgixyN3ArLq2lnZ8isDYfUSueO6nH/rteUaSvAo5tYY1 Lz62NsHMjupU0kBdb6o3T8wrXB3EojMqTz31cUp4MJfcH3oBngmW0H711OKnyAaXhXSy S1TOsvp+K1O2C0LlnLCaJFS2R96chKC/0j9Q6OkdshJ1TQ4RF8hwFhktcBSI6GXPbcsr QgwWzyvLs2aFw/6WUN2ZIKE8+Nvn+VPOn4ei8HKq+ULEE8rEf4axnJfmYJrCDwDSBUwh umFHV3BSYY3rxwDOfrnhAmv7hFlE4cvAJLXuLQSS8rrKwNWBChYlTjiywNWT9OQsmhd7 X+gQ== X-Gm-Message-State: ALoCoQmt2aUIpqFqVEzjx7bbFqAjrGFYoU1KXX03kzrQnGZEvedJ7r4FR1nDOhrQimLaSd2rYvAiZSjeZUDImACe/Sf3KHoXlQ== X-Received: by 10.28.13.213 with SMTP id 204mr32409643wmn.16.1452798978754; Thu, 14 Jan 2016 11:16:18 -0800 (PST) Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com. [74.125.82.50]) by smtp.gmail.com with ESMTPSA id z127sm28214385wme.2.2016.01.14.11.16.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Jan 2016 11:16:17 -0800 (PST) Received: by mail-wm0-f50.google.com with SMTP id l65so358041085wmf.1; Thu, 14 Jan 2016 11:16:17 -0800 (PST) X-Received: by 10.194.79.8 with SMTP id f8mr5874682wjx.6.1452798977237; Thu, 14 Jan 2016 11:16:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.194.170.199 with HTTP; Thu, 14 Jan 2016 11:15:57 -0800 (PST) In-Reply-To: <20160114171341.GY17997@ZenIV.linux.org.uk> References: <20151209053209.GV20997@ZenIV.linux.org.uk> <1449639295-20512-6-git-send-email-viro@ZenIV.linux.org.uk> <20160114152553.GW17997@ZenIV.linux.org.uk> <20160114162333.GX17997@ZenIV.linux.org.uk> <20160114171341.GY17997@ZenIV.linux.org.uk> From: Tomeu Vizoso Date: Thu, 14 Jan 2016 20:15:57 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 06/11] don't put symlink bodies in pagecache into highmem To: Al Viro Cc: "linux-kernel@vger.kernel.org" , Linus Torvalds , Neil Brown , linux-fsdevel@vger.kernel.org Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 14 January 2016 at 18:13, Al Viro wrote: > On Thu, Jan 14, 2016 at 05:57:42PM +0100, Tomeu Vizoso wrote: >> Here it is: >> >> [ 170.715356] inode: ec8c30b0, pages: 1 >> [ 170.719014] page_address: (null) >> >> https://lava.collabora.co.uk/scheduler/job/127698/log_file > > Lovely... And that looks like the first time that inode hits > nfs_get_link(). Ho-hum... > > Could you add WARN_ON(inode->i_mapping.nrpages) in inode_nohighmem() > and see if that triggers? It really shouldn't (we hit it after iget5_locked() Indeed :( https://lava.collabora.co.uk/scheduler/job/127782/log_file I have ran out of time for today, but tomorrow can do more tests if needed. Regards, Tomeu > in nfs_fhget() has returned us a new inode, and there shouldn't be a chance > for any pages to get in there between struct inode allocation and that > point), but then neither should highmem pages be added to address_space > without __GFP_HIGHMEM in ->flags... --- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/inode.c b/fs/inode.c index 1e6dd388ba7f..b957744376e8 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -2031,6 +2031,7 @@ EXPORT_SYMBOL(inode_set_flags); void inode_nohighmem(struct inode *inode) { + WARN_ON(inode->i_mapping->nrpages); mapping_set_gfp_mask(inode->i_mapping, GFP_USER); } EXPORT_SYMBOL(inode_nohighmem);