mbox series

[GIT,PULL] orangefs: an adjustment and a fix...

Message ID CAOg9mSR9CM-DV1eqL58HM+m_6fbwgU7KFs3Sab0=A7BOvqoPYQ@mail.gmail.com (mailing list archive)
State New
Headers show
Series [GIT,PULL] orangefs: an adjustment and a fix... | expand

Pull-request

https://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux.git tags/for-linus-5.13-ofs2

Message

Mike Marshall June 26, 2021, 2:14 p.m. UTC
The following changes since commit 13311e74253fe64329390df80bed3f07314ddd61:

  Linux 5.13-rc7 (2021-06-20 15:03:15 -0700)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux.git
tags/for-linus-5.13-ofs2

for you to fetch changes up to 1815bba0a5c935d60f0fa180873d9152feb29d09:

  orangefs: fix orangefs df output. (2021-06-25 12:00:04 -0400)

----------------------------------------------------------------
Orangefs: and adjustment and a fix

If it is not too late for these... the readahead adjustment
was suggested by Matthew Wilcox and looks like how I should
have written it in the first place... the "df fix" was
suggested by Walt Ligon, some Orangefs users have been complaining
about whacky df output...

----------------------------------------------------------------
Mike Marshall (2):
      orangefs: readahead adjustment
      orangefs: fix orangefs df output.

 fs/orangefs/inode.c | 6 +++---
 fs/orangefs/super.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Linus Torvalds June 26, 2021, 5:02 p.m. UTC | #1
On Sat, Jun 26, 2021 at 7:14 AM Mike Marshall <hubcap@omnibond.com> wrote:
>
> If it is not too late for these... the readahead adjustment
> was suggested by Matthew Wilcox and looks like how I should
> have written it in the first place...

It wasn't too late - I pulled these.

And then I un-pulled them. You removed all the uses of "file", but
left the variable, so it all warns about

  fs/orangefs/inode.c: In function ‘orangefs_readahead’:
  fs/orangefs/inode.c:252:22: warning: unused variable ‘file’
[-Wunused-variable]
    252 |         struct file *file = rac->file;
        |                      ^~~~

so clearly this has gotten absolutely zero testing.

           Linus
Mike Marshall June 27, 2021, 2:50 p.m. UTC | #2
Fair enough... I promise it is my generally my habit to do
this and pay attention to the output before I send stuff
to you:

 1011  rm fs/orangefs/*.o
 1012  make

>>so clearly this has gotten absolutely zero testing.

I wouldn't do you that way :-) ... I ran this through xfstests
and left it on linux-next for a cycle.

-Mike

On Sat, Jun 26, 2021 at 1:02 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Sat, Jun 26, 2021 at 7:14 AM Mike Marshall <hubcap@omnibond.com> wrote:
> >
> > If it is not too late for these... the readahead adjustment
> > was suggested by Matthew Wilcox and looks like how I should
> > have written it in the first place...
>
> It wasn't too late - I pulled these.
>
> And then I un-pulled them. You removed all the uses of "file", but
> left the variable, so it all warns about
>
>   fs/orangefs/inode.c: In function ‘orangefs_readahead’:
>   fs/orangefs/inode.c:252:22: warning: unused variable ‘file’
> [-Wunused-variable]
>     252 |         struct file *file = rac->file;
>         |                      ^~~~
>
> so clearly this has gotten absolutely zero testing.
>
>            Linus