| Message ID | CAOg9mSSjfxiZ960tpADgVmndxXQpC7ag9QZSz68NbdeGn+yW9g@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, May 20, 2016 at 04:51:30PM -0400, Mike Marshall wrote: > Hi everyone... > > While fixing a couple of LTP regressions in the out-of-tree Orangefs > kernel module, I think I found a problem with the pwrite04 test, > here's what I think was meant: > > # git diff testcases/kernel/syscalls/pwrite/pwrite04.c > diff --git a/testcases/kernel/syscalls/pwrite/pwrite04.c > b/testcases/kernel/syscalls/pwrite/pwrite04.c > index b297682..4ca7dc1 100644 > --- a/testcases/kernel/syscalls/pwrite/pwrite04.c > +++ b/testcases/kernel/syscalls/pwrite/pwrite04.c > @@ -196,9 +196,9 @@ int main(int ac, char *av[]) > > } > if (statbuf.st_size != K5) { > - tst_resm(TFAIL, "file size is %ld != K4", > + tst_resm(TFAIL, "file size is %ld != K5", > statbuf.st_size); > - > + cleanup(); > } > tst_resm(TPASS, "O_APPEND test passed."); > > Should I even be talking about this here, or should I go find > the github maintainers of LTP and ask them about it? Can you please send a patch to ltp list (ltp@lists.linux.it)? That's where ltp developments and discussions happen. Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/testcases/kernel/syscalls/pwrite/pwrite04.c b/testcases/kernel/syscalls/pwrite/pwrite04.c index b297682..4ca7dc1 100644 --- a/testcases/kernel/syscalls/pwrite/pwrite04.c +++ b/testcases/kernel/syscalls/pwrite/pwrite04.c @@ -196,9 +196,9 @@ int main(int ac, char *av[]) } if (statbuf.st_size != K5) { - tst_resm(TFAIL, "file size is %ld != K4", + tst_resm(TFAIL, "file size is %ld != K5", statbuf.st_size); - + cleanup(); } tst_resm(TPASS, "O_APPEND test passed.");